chore: backport test changes while adjusting feature flags in v2 #14233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nija-at
force-pushed
the
nija-at/backport-unexpire
branch
from
e3299e0 to
1a6291a
Compare
The defaults for some feature flags in CDKv2 are changing from 'false' to 'true'. Some test are sensitive to this change. This change modifies such tests to explicitly set the value of the feature flag so that its behavior is consistent across the two versions of the CDK.
nija-at
force-pushed
the
nija-at/backport-unexpire
branch
from
1a6291a to
62bf056
Compare
rix0rrr
approved these changes
Apr 19, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…#14233) This is a backport of 81148f0. The defaults for some feature flags in CDKv2 are changing from 'false' to 'true'. Some test are sensitive to this change. This change modifies such tests to explicitly set the value of the feature flag so that its behavior is consistent across the two versions of the CDK. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of 81148f0.
The defaults for some feature flags in CDKv2 are changing from 'false'
to 'true'.
Some test are sensitive to this change. This change modifies such tests
to explicitly set the value of the feature flag so that its behavior is
consistent across the two versions of the CDK.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license