Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(prlint): stricter validation around breaking changes #14278

Merged
merged 4 commits into from
Apr 21, 2021
Merged

chore(prlint): stricter validation around breaking changes #14278

merged 4 commits into from
Apr 21, 2021

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Apr 20, 2021

Increase the scrutiny on how breaking changes are formatted.

Motivation
A previous PR - #14227 - incorrectly specified breaking changes that
standard-release failed to record in the changelog.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

chore(prlint): stricter validation around breaking changes
a031df8 
Increase the scrutiny on how breaking changes are formatted.

Motivation
A previous PR - #14227 - incorrectly specified breaking changes that
standard-release failed to record in the changelog.
@gitpod-io
Copy link

gitpod-io bot commented Apr 20, 2021 •
edited
Loading

@nija-at nija-at self-assigned this Apr 20, 2021
@nija-at nija-at requested review from NetaNir and a team April 20, 2021 17:17
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 20, 2021
@nija-at
Copy link
Contributor Author

nija-at commented Apr 20, 2021 •
edited
Loading

Testing

  • Test locally against a valid (14219) and invalid PR (14227)
  • Test locally against a PR that has breaking change clause but incorrect module name in the title.

NetaNir
NetaNir approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@NetaNir NetaNir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@nija-at nija-at marked this pull request as ready for review April 21, 2021 10:47
@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 016611d into master Apr 21, 2021
@mergify mergify bot deleted the nija-at/prlint-breakingchanges branch April 21, 2021 12:07
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 3468138
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

john-tipper pushed a commit to john-tipper/aws-cdk that referenced this pull request May 10, 2021
@john-tipper
chore(prlint): stricter validation around breaking changes (aws#14278)
eed4476 
Increase the scrutiny on how breaking changes are formatted.

Motivation
A previous PR - aws#14227 - incorrectly specified breaking changes that
standard-release failed to record in the changelog.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@hollanddd
chore(prlint): stricter validation around breaking changes (aws#14278)
4af4d98 
Increase the scrutiny on how breaking changes are formatted.

Motivation
A previous PR - aws#14227 - incorrectly specified breaking changes that
standard-release failed to record in the changelog.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NetaNir NetaNir NetaNir approved these changes

Assignees

@nija-at nija-at

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nija-at @aws-cdk-automation @NetaNir