-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: keep core documentation in sync between @aws-cdk/core and aws-cdk-lib #14280
Conversation
…cdk-lib Users of CDKv1 use the @aws-cdk/core documentation as the landing point for documentation on core concepts like stacks, durations, references, etc. For CDKv2 users, the same landing point is aws-cdk-lib, which currently has very limited documentation. This change introduces a pkglint rule to keep a subset of the two READMEs in sync. This was chosen over syncing the entire README as the titles, heading, stability markings, etc. needed to be different between the two packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You crazy
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…cdk-lib (aws#14280) Users of CDKv1 use the @aws-cdk/core documentation as the landing point for documentation on core concepts like stacks, durations, references, etc. For CDKv2 users, the same landing point is aws-cdk-lib, which currently has very limited documentation. This change introduces a pkglint rule to keep a subset of the two READMEs in sync. This was chosen over syncing the entire README as the titles, heading, stability markings, etc. needed to be different between the two packages. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…cdk-lib (aws#14280) Users of CDKv1 use the @aws-cdk/core documentation as the landing point for documentation on core concepts like stacks, durations, references, etc. For CDKv2 users, the same landing point is aws-cdk-lib, which currently has very limited documentation. This change introduces a pkglint rule to keep a subset of the two READMEs in sync. This was chosen over syncing the entire README as the titles, heading, stability markings, etc. needed to be different between the two packages. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Users of CDKv1 use the @aws-cdk/core documentation as the landing point for
documentation on core concepts like stacks, durations, references, etc. For
CDKv2 users, the same landing point is aws-cdk-lib, which currently has very
limited documentation.
This change introduces a pkglint rule to keep a subset of the two READMEs in
sync. This was chosen over syncing the entire README as the titles, heading,
stability markings, etc. needed to be different between the two packages.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license