chore: Add note that assets are not account for in diff #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
force-pushed
the
rmuller/diff-warning
branch
from
34084fa
to
380e740
Compare
eladb
approved these changes
Dec 27, 2018
| @@ -88,3 +93,7 @@ function buildLogicalToPathMap(template: cxapi.SynthesizedStack) { | |||
| } | |||
| return map; | |||
| } | |||
|
|
|||
| function _hasAssets(stack: cxapi.SynthesizedStack) { | |||
| return Object.values(stack.metadata).find(entries => entries.find(entry => entry.type === cxapi.ASSET_METADATA) != null) != null; | |||
There was a problem hiding this comment.
I am curious why you find it important to add != null?
There was a problem hiding this comment.
The outer-most one is to force into a boolean context (for tsc to map it as a boolean), the middle one is out of habit.
eladb
pushed a commit
that referenced
this pull request
Oct 3, 2019
The `NestedStack` construct is a special kind of `Stack`. Any resource defined within its scope will be included in a separate template from the parent stack. The template for the nested stack is synthesized into the cloud assembly but not treated as a deployable unit but rather as a file asset. This will cause the CLI to upload it to S3 and wire it's coordinates to the parent stack so we can reference its S3 URL. To support references between the parent stack and the nested stack, we abstracted the concept of preparing cross references by inverting the control of `consumeReference` from the reference object itself to the `Stack` object. This allows us to override it at the `NestedStack` level (through `prepareCrossReference`) and mutate the token accordingly. When an outside resource is referenced within the nested stack, it is wired through a synthesized CloudFormation parameter. When a resource inside the nested stack is referenced from outside, it will be wired through a synthesized CloudFormation output. This works for arbitrarily deep nesting. When an asset is referenced within a nested stack, it will be added to the top-level stack and wired through the asset parameter reference (like any other reference). Fixes #239 Fixes #395 Related #3437 Related #1439 Related #3463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1327
Related to #395
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.