Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ecr-assets): reference cdk-ecr-deployment in readme #14488

Merged
merged 4 commits into from
May 4, 2021

Conversation

eladb
Copy link
Contributor

@eladb eladb commented May 2, 2021

As a possible solution for #12597, refer to the 3rd-party module cdk-ecr-deployment which supports deploying image assets to a specific ECR repository.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

As a possible solution for #12597, refer to the 3rd-party module `cdk-ecr-deployment` which supports deploying image assets to a specific ECR repository.
@gitpod-io
Copy link

gitpod-io bot commented May 2, 2021

@eladb eladb requested review from nija-at and skinny85 May 2, 2021 10:31
@github-actions github-actions bot added @aws-cdk/assets Related to the @aws-cdk/assets package @aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets labels May 2, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 2, 2021
@mergify
Copy link
Contributor

mergify bot commented May 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ad83375 into master May 4, 2021
@mergify mergify bot deleted the benisrae/ecr-deployment-reference branch May 4, 2021 18:11
@mergify
Copy link
Contributor

mergify bot commented May 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: ff1e4a0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

john-tipper pushed a commit to john-tipper/aws-cdk that referenced this pull request May 10, 2021
As a possible solution for aws#12597, refer to the 3rd-party module `cdk-ecr-deployment` which supports deploying image assets to a specific ECR repository.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
As a possible solution for aws#12597, refer to the 3rd-party module `cdk-ecr-deployment` which supports deploying image assets to a specific ECR repository.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/assets Related to the @aws-cdk/assets package @aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants