Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-event-sources): incorrect documented defaults for stream types #14562

Merged
merged 3 commits into from
May 12, 2021
Merged

fix(lambda-event-sources): incorrect documented defaults for stream types #14562

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4adcc0d
fix(lambda-event-sources): incorrect documented defaults for stream t…
May 6, 2021
7072fdc
Update packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts
May 11, 2021
088fa3e
Merge branch 'master' into nija-at/fix-eventsource-defaults
May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export interface StreamEventSourceProps {
* * Minimum value of 60 seconds
* * Maximum value of 7 days
*
* @default Duration.days(7)
* @default - the record is available for processing until it expires
nija-at marked this conversation as resolved.
Show resolved Hide resolved
*/
readonly maxRecordAge?: Duration;

Expand All @@ -51,7 +51,7 @@ export interface StreamEventSourceProps {
* * Minimum value of 0
* * Maximum value of 10000
*
* @default 10000
* @default - retry until the record expires
*/
readonly retryAttempts?: number;

Expand Down