feat(core): allow setting termination protection on stacks #14719
Conversation
This commit silences several linter warnings in the stack.ts file.
This commit adds a getter and setter for Stack termination protection. This allows termination protection to be configured after the Stack has been constructed. fixes aws#14463
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
We don't normally use getter and setter in the public API (searching for public set in the codebase returns very few results). The reason behind it that for values known at construction time, this added mutability does not adds value in terms of API ergonomics.
If there is a use case Im missing, let me know.
Are you saying that #14463 is a won't fix, or you'd just prefer a different implementation here? If you'd like a different implementation here, I'm open to update this however you'd like. |
|
Ping @NetaNir regarding my previous comment ^ |
@NetaNir The use case is described in my original issue that @cjihrig linked. In general, if you don't allow fields to be mutable after construction, that basically rules out many use cases for Aspects. |
This PR adds a getter and setter for Stack termination protection. This allows termination protection to be configured after the Stack has been constructed.
fixes #14463
This PR also includes a commit that fixes several linter warnings in stack.ts.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license