feat(ecs-patterns): Add support for Docker labels to ECS Patterns #14783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
ABevier
changed the title
slmingol
approved these changes
May 19, 2021
salscode
approved these changes
May 27, 2021
peterwoodworth
added
the
@aws-cdk/aws-ecs-patterns
SoManyHs
previously approved these changes
Jun 9, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
SoManyHs
approved these changes
Jun 9, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…s#14783) I have the need to pass docker labels to containers created with the ECS Patterns L3 construct. There wasn't an easy way to add them after construction and passing an entire TaskDefinition seemed suboptimal. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have the need to pass docker labels to containers created with the ECS Patterns L3 construct. There wasn't an easy way to add them after construction and passing an entire TaskDefinition seemed suboptimal.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license