docs(lambda-python): recommend lockfiles #14847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since python bundles use source hashes (and as a general best practice), add a recommendation to use a dependency lockfile. Fixes #14607
|
|
nija-at
reviewed
May 26, 2021
| @@ -44,6 +44,16 @@ If `requirements.txt` or `Pipfile` exists at the entry path, the construct will | |||
| all required modules in a [Lambda compatible Docker container](https://gallery.ecr.aws/sam/build-python3.7) | |||
| according to the `runtime`. | |||
|
|
|||
| Python bundles are only recreated and published when a file in a source directory has changed. | |||
There was a problem hiding this comment.
Who generates this lock file and when/who updates it? Does the bundling phase of PythonFunction do it?
There was a problem hiding this comment.
This needs to be done by the user
otaviomacedo
approved these changes
Jun 8, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Since python bundles use source hashes (and as a general best practice), add a recommendation to use a dependency lockfile. Fixes aws#14607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since python bundles use source hashes (and as a general best practice), add a recommendation to use a dependency lockfile.
Fixes #14607
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license