-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(diff): Better diff of random objects #1488
Conversation
Use a unified diff format to render differences in arbitrary values, making it easier to understand what is changing in possibly large JSON structures, for example.
Can you upload a screen shot? |
8c097a1
to
63200c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to run toolkit integ tests
Integration tests were successful! |
Can we reduce the default context some? I'd prefer something like 3. The diff takes up a lot of vertical space this way. |
@rix0rrr - yeah that'll match the defaults of most |
Use a unified diff format to render differences in arbitrary values,
making it easier to understand what is changing in possibly large JSON
structures, for example.
The number of context lines used when rendering the JSON differences
can be customized using the
--context-lines
option ofcdk diff
,which has a default value of
3
.Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.