Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(route53resolver): DNS Firewall #15031
feat(route53resolver): DNS Firewall #15031
Changes from 14 commits
7e33f62
0936e83
93dec85
2c9c641
7a96386
fd429da
f37c494
1a5315a
fee2a6d
88dbdc8
c62af08
59b3e5c
29af36f
b282f82
7ebe7f7
7c864a7
aa5de11
9452284
583acfc
b1f0350
484edad
16cdf9c
5b62359
f01ceeb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No underscores are allowed in domain names, IIRC, and your regex isn't checking for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Underscores are unusual but allowed in (sub)domains names and
\w
includes underscores (\w = [a-zA-Z0-9_]
)https://stackoverflow.com/questions/2180465/can-domain-name-subdomains-have-an-underscore-in-it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the
{1,128}
part which was incorrect and actually applies to the domain list name.