Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(aws-ecs): DRY up propagateTaskTagsFrom #15105

Merged
merged 3 commits into from
Jun 14, 2021
Merged

refactor(aws-ecs): DRY up propagateTaskTagsFrom #15105

merged 3 commits into from
Jun 14, 2021

Conversation

SoManyHs
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 12, 2021

@SoManyHs SoManyHs added @aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort labels Jun 12, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 12, 2021
upparekh
upparekh approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@upparekh upparekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c6d5d18
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7ea9e48 into aws:master Jun 14, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@SoManyHs @hollanddd
refactor(aws-ecs): DRY up propagateTaskTagsFrom (aws#15105)
161db8d 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upparekh upparekh upparekh approved these changes

@madeline-k madeline-k Awaiting requested review from madeline-k

Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SoManyHs @aws-cdk-automation @upparekh