feat(aws-cdk): better stack dependency handling #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically include stacks that have a dependency relationship with the requested stacks, unless `--exclusively` (`-e`) is passed on the command line. Fixes #1505.
RomainMuller
approved these changes
Jan 10, 2019
| @@ -53,13 +53,16 @@ async function parseCommandLineArguments() { | |||
| .command([ 'list', 'ls' ], 'Lists all stacks in the app', yargs => yargs | |||
| .option('long', { type: 'boolean', default: false, alias: 'l', desc: 'display environment information for each stack' })) | |||
| .command([ 'synthesize [STACKS..]', 'synth [STACKS..]' ], 'Synthesizes and prints the CloudFormation template for this stack', yargs => yargs | |||
| .option('exclusively', { type: 'boolean', alias: 'e', desc: 'only deploy requested stacks, don\'t include dependencies' }) | |||
There was a problem hiding this comment.
I'd call this --ignore-dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two improvements to stack dependency handling in the toolkit:
use exports and
Fn::ImportValue. Fixes Toolkit:cdk destroyneeds to reverse stacks w/ dependencies based on topological ordering #1508.with the requested stacks, unless
--exclusively(-e) ispassed on the command line. Fixes Toolkit: automatically select stacks with dependencies during
cdk deploy#1505.Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.