Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(servicecatalogappregistry): initial L2 construct for Application #15140

Merged
merged 16 commits into from
Jun 22, 2021

Commits on Jun 15, 2021

  1. Initial L2 construct for appregisty application

    Service Catalog AppRegistry application construct initial base version.
    Please note the ARNS for this construct have two '/' in them hence the slightly
    different ARN parsing
    
    Testing done
    ------------------
    * `yarn build && yarn test`
    * `yarn integ`
    
    Co-authored-by: Dillon Ponzo <dponzo18@gmail.com>
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    Aidan Crank committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    e93bd3e View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Adding AppRegistry Application construct

    Addressing comments from PR
    
    Co-authored-by: Dillon Ponzo <dponzo18@gmail.com>
    Aidan Crank and dponzo committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    be2e930 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    27f685c View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Configuration menu
    Copy the full SHA
    6911452 View commit details
    Browse the repository at this point in the history
  2. Addressing comments from PR

    Addressing minor formatting comments from PR review.
    Added functionality to skip validation if we are passed a token for properties,
    and added unit tests for those cases
    
    Testing done
    ------------------
    * `yarn build && yarn lint && yarn test`
    
    Co-authored-by: Dillon Ponzo <dponzo18@gmail.com>
    Aidan Crank and dponzo committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    517df1b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    40c8ba4 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Fixing input validation tests

    Updating unit tests to properly test that token inputs do
    end up getting created in template and not just validating it throwing
    a specific error
    
    Testing done
    ------------------
    * `yarn build && yarn lint && yarn test`
    
    Co-authored-by Dillon Ponzo <dponzo18@gmail.com>
    Aidan Crank committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    0ab78e0 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'appregistry_l2_construct' of github.com:arcrank/aws-cdk…

    … into appregistry_l2_construct
    
    merging branch
    Aidan Crank committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    854cb01 View commit details
    Browse the repository at this point in the history
  3. removing trailing whitespaces...

    Aidan Crank committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    1ba5eed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5b763b3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    427e54a View commit details
    Browse the repository at this point in the history
  6. Update packages/@aws-cdk/aws-servicecatalogappregistry/README.md

    Co-authored-by: Adam Ruka <adamruka85@gmail.com>
    arcrank and skinny85 authored Jun 21, 2021
    Configuration menu
    Copy the full SHA
    c652129 View commit details
    Browse the repository at this point in the history
  7. Update packages/@aws-cdk/aws-servicecatalogappregistry/lib/applicatio…

    …n.ts
    
    Co-authored-by: Adam Ruka <adamruka85@gmail.com>
    arcrank and skinny85 authored Jun 21, 2021
    Configuration menu
    Copy the full SHA
    be8b38b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    46abb81 View commit details
    Browse the repository at this point in the history
  9. updating ARN parsing and error messaging

    Aidan Crank committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    bbfb0f1 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Configuration menu
    Copy the full SHA
    48ffa72 View commit details
    Browse the repository at this point in the history