Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): parsing an ARN with a slash after a colon in the resource part fails #15166

Merged
merged 2 commits into from
Jun 21, 2021
Merged

fix(core): parsing an ARN with a slash after a colon in the resource part fails #15166

merged 2 commits into from
Jun 21, 2021
+242 −69

Commits on Jun 21, 2021

  1. fix(core): parsing an ARN with a slash after a colon in the resource … 

    …part fails

New-style ARNs are of the form 'arn:aws:s4:us-west-1:12345:/resource-type/resource-name'.
We didn't handle that correctly in parseArn(), and instead returned an `undefined` resource,
which funnily enough should never happen according to our types.

Introduce the concept of ARN formats,
represented by an enum in core,
and replace the `Stack.parseArn()` method by a new one `Stack.splitArn()`,
taking that enum as a required second argument.

Spotted in https://github.com/aws/aws-cdk/pull/15140/files#r653112073
    @skinny85
    skinny85 committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    d3c1ce0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/arn-parse-slash-after-colon

    @mergify
    mergify[bot] authored Jun 21, 2021
    Configuration menu
    Copy the full SHA
    e37d4dc View commit details
    Browse the repository at this point in the history