fix(stepfunctions-tasks): checking for task token in EcsRunTask containerOverrides causes memory explosion #15187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainerOverrides environment the runTask containerOverrides had references to the entire construct tree causing a large amount of recursion when trying to validate that the task token was provided. the only place for the task token to appear is in the environment of a containerOverride, so only check for it there I also updated the error to mention JsonPath instead of Context since Context is deprecated fixes #15124 in addition to the unit tests, I packaged the library to dotnet and succesfully synthed the reproduction mentioned in #15124 thanks to @BenChaimberg for providing the suggested fix
|
|
|
Do we need to make the same change for run-ecs-task-base.ts? It's marked deprecated, but I believe the same issue exists there. |
specifically mention in the error that the task token is expected in the environment property of at least one containerOverride
BenChaimberg
changed the title
BenChaimberg
previously requested changes
Jun 18, 2021
There was a problem hiding this comment.
Thank you so much for your contribution and investigation! Just some small comments.
Do we need to make the same change for run-ecs-task-base.ts? It's marked deprecated, but I believe the same issue exists there.
Yes, please.
packages/@aws-cdk/aws-stepfunctions-tasks/test/ecs/run-tasks.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/test/ecs/run-tasks.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/test/ecs/run-tasks.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/test/ecs/run-tasks.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/test/ecs/run-tasks.test.ts
Outdated
Show resolved
Hide resolved
rename variable in containerOverride's map arrow function to mbe more clear propagate the same change EcsRunTaskBase since the same defect can occur there add the same tests for EcsrunTaskBase to catch future regression update EcsRunTaskBase task token validation error message to be more accurate and align with the same error throw in runTask
mergify
bot
dismissed
BenChaimberg’s stale review
Pull request has been modified.
BenChaimberg
approved these changes
Jun 18, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
dillon-odonovan
deleted the
fix/run-ecs-task-check-only-container-override-env
branch
matthewsvu
pushed a commit
to matthewsvu/aws-cdk
that referenced
this pull request
Jun 22, 2021
…inerOverrides causes memory explosion (aws#15187) EcsRunTask containerOverrides had references to the entire construct tree causing a large amount of recursion when trying to validate that the task token was provided in the waitForTaskToken integration pattern. The only place for the task token to appear is in the environment of a containerOverride, so we should only check for it there. I also updated the error to mention JsonPath instead of Context since Context is deprecated. In addition to the unit tests, I packaged the library to dotnet and succesfully synthed the minimal reproduction. thanks to @BenChaimberg for providing the suggested fix fixes aws#15124 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…inerOverrides causes memory explosion (aws#15187) EcsRunTask containerOverrides had references to the entire construct tree causing a large amount of recursion when trying to validate that the task token was provided in the waitForTaskToken integration pattern. The only place for the task token to appear is in the environment of a containerOverride, so we should only check for it there. I also updated the error to mention JsonPath instead of Context since Context is deprecated. In addition to the unit tests, I packaged the library to dotnet and succesfully synthed the minimal reproduction. thanks to @BenChaimberg for providing the suggested fix fixes aws#15124 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EcsRunTask containerOverrides had references to the entire construct tree causing a large amount of recursion
when trying to validate that the task token was provided in the waitForTaskToken integration pattern. The only place for the task token to appear is in the environment of a containerOverride, so we should only check for it there.
I also updated the error to mention JsonPath instead of Context since Context is deprecated.
In addition to the unit tests, I packaged the library to dotnet and succesfully synthed the minimal reproduction.
thanks to @BenChaimberg for providing the suggested fix
fixes #15124
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license