Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dynamodb): allow using Kinesis stream in Table #15199

Merged
merged 2 commits into from
Jun 21, 2021
Merged

feat(dynamodb): allow using Kinesis stream in Table #15199

merged 2 commits into from
Jun 21, 2021

Conversation

rrhodes
Copy link
Contributor

@rrhodes rrhodes commented Jun 18, 2021 •
edited by skinny85
Loading

Add support for Kinesis Streams in DynamoDB tables with a new kinesisStreamArn table option.

Closes #14534

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 18, 2021

skinny85
skinny85 previously requested changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @rrhodes! In general, in the L2 libraries, we use the types from other libraries for integrations, instead of relying on strings. If you could change that one small thing, we will get this puppy merged!

packages/@aws-cdk/aws-dynamodb/lib/table.ts Outdated Show resolved Hide resolved
@peterwoodworth peterwoodworth added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label Jun 18, 2021
@mergify mergify bot dismissed skinny85’s stale review June 20, 2021 09:27

Pull request has been modified.

@rrhodes rrhodes force-pushed the feature/14534-dynamodb-kinesis-streaming-destination branch from 1fcd17a to 6759a0a Compare June 20, 2021 09:31
@rrhodes rrhodes requested a review from skinny85 June 20, 2021 09:33
skinny85
skinny85 approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @rrhodes, thanks for the contribution!

Actually, please also move this to TableProps instead of TableOptions.

Happy to move this. Interested to hear how you decide what belongs in TableOptions and what goes to TableProps?

TableOptions are also used as input to the now-deprecated GlobalTable construct. I don't want to support that option there, so that's why moving them to TableProps makes sense.

@skinny85 skinny85 changed the title feat(dynamodb): kinesis stream specification feat(dynamodb): Kinesis stream specification Jun 21, 2021
@skinny85 skinny85 changed the title feat(dynamodb): Kinesis stream specification feat(dynamodb): allow using Kinesis stream in Table Jun 21, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 435573e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7bc6c6e into aws:master Jun 21, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rrhodes rrhodes deleted the feature/14534-dynamodb-kinesis-streaming-destination branch June 21, 2021 20:18
Seiya6329 pushed a commit to Seiya6329/aws-cdk that referenced this pull request Jun 22, 2021
@rrhodes @Seiya6329
feat(dynamodb): allow using Kinesis stream in Table (aws#15199)
9087cf2 
Add support for Kinesis Streams in DynamoDB tables with a new `kinesisStreamArn` table option.

Closes aws#14534

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
matthewsvu pushed a commit to matthewsvu/aws-cdk that referenced this pull request Jun 22, 2021
@rrhodes
feat(dynamodb): allow using Kinesis stream in Table (aws#15199)
2e1b511 
Add support for Kinesis Streams in DynamoDB tables with a new `kinesisStreamArn` table option.

Closes aws#14534

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@rrhodes @hollanddd
feat(dynamodb): allow using Kinesis stream in Table (aws#15199)
a460730 
Add support for Kinesis Streams in DynamoDB tables with a new `kinesisStreamArn` table option.

Closes aws#14534

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-dynamodb): Add enableKinesisStreamingDestination
4 participants
@rrhodes @aws-cdk-automation @skinny85 @peterwoodworth