add packages.txt to github pages #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
Jan 11, 2019
eladb
reviewed
Jan 11, 2019
| @@ -4,6 +4,8 @@ set -euo pipefail | |||
| # render docs to docs/dist | |||
| (cd docs && bash ./build-docs.sh) | |||
|
|
|||
| lerna ls > docs/dist/packages.txt | |||
There was a problem hiding this comment.
Might not be sufficient to actually be able to implement our installation canaries. I would argue that we probably need the names of the modules for every package manager that we publish into. Otherwise we will need heuristics about converting the javascript names to other languages and that's not possible because there are special cases there.
There was a problem hiding this comment.
I think the .jsii files are a better artifact to publish to our docs website (or a .zip file with all the .jsii files). That will include all the needed information (and also all of our type system, which is useful for other purposes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need access to packages.txt for unit tests, this will make them available on github.io.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.