Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docdb): cluster - deletion protection #15216

Merged
merged 3 commits into from
Aug 24, 2021
Merged

feat(docdb): cluster - deletion protection #15216

merged 3 commits into from
Aug 24, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 20, 2021

This commit adds support for deletionProtection on docdb DatabaseClusters.

Fixes: #15170

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 20, 2021

@cjihrig cjihrig mentioned this pull request Jun 22, 2021
Closed
2 tasks
peterwoodworth
peterwoodworth previously approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you for adding this!

@peterwoodworth peterwoodworth added the @aws-cdk/aws-docdb Related to Amazon DocumentDB label Jul 7, 2021
@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 13, 2021

Thanks @peterwoodworth. Is there anything else that I need to do here to get this landed?

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 19, 2021

ping?

@skinny85
Copy link
Contributor

@cjihrig like the failing check says:

Error: Features must contain a change to a README file

So, you need to update the ReadMe file to mention this new feature 🙂.

cjihrig added 2 commits August 23, 2021 22:12
@cjihrig
feat(docdb): cluster - deletion protection
b6cacde 
This commit adds support for `deletionProtection` on docdb
`DatabaseCluster`s.

Fixes: aws#15170
@cjihrig
fixup! feat(docdb): cluster - deletion protection
5ae2766
@mergify mergify bot dismissed peterwoodworth’s stale review August 24, 2021 02:24

Pull request has been modified.

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 24, 2021

@skinny85 updated the README, PTAL.

@skinny85
Copy link
Contributor

@peterwoodworth is the one doing the review, I'll leave the final word to him 🙂.

peterwoodworth
peterwoodworth approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0f7beb2 into aws:master Aug 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: d7df804
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@cjihrig cjihrig deleted the docdb-del-prot branch August 24, 2021 19:00
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@cjihrig @hollanddd
feat(docdb): cluster - deletion protection (aws#15216)
54af83c 
This commit adds support for `deletionProtection` on docdb `DatabaseCluster`s.

Fixes: aws#15170

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
@cjihrig @TikiTDO
feat(docdb): cluster - deletion protection (aws#15216)
3b41873 
This commit adds support for `deletionProtection` on docdb `DatabaseCluster`s.

Fixes: aws#15170

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
@cjihrig @david-doyle-as24
feat(docdb): cluster - deletion protection (aws#15216)
c47f288 
This commit adds support for `deletionProtection` on docdb `DatabaseCluster`s.

Fixes: aws#15170

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwoodworth peterwoodworth peterwoodworth approved these changes

Assignees
No one assigned
Labels
@aws-cdk/aws-docdb Related to Amazon DocumentDB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-docdb - missing deletion protection
4 participants
@cjihrig @skinny85 @aws-cdk-automation @peterwoodworth