Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3): export bucket websiteURL (#1521) #1522

Closed
wants to merge 26 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
497620d
feat(s3): export bucket websiteURL
AlexChesters Jan 11, 2019
f6a3bfa
fix
AlexChesters Jan 11, 2019
c2aeebd
rename bucketWebsiteURL to bucketWebsiteUrl
AlexChesters Jan 14, 2019
a36ac08
update implementation to return WebsiteURL value
AlexChesters Jan 14, 2019
7bafbff
add unit test
AlexChesters Jan 14, 2019
1724161
feat(apigateway): add tracingEnabled property to APIGW Stage (#1482)
workeitel Jan 6, 2019
a4645f2
feat(aws-ecs): add support Amazon Linux 2 (#1484)
cohalz Jan 6, 2019
b22cf0c
feat(aws-kms): allow tagging kms keys (#1485)
rsmogura Jan 7, 2019
19c9392
chore: Document return behavior of cdk diff (#1446)
RomainMuller Jan 7, 2019
5096201
fix(elbv2): unable to specify load balancer name (#1486)
Jan 7, 2019
9bae09b
feat(diff): Better diff of random objects (#1488)
RomainMuller Jan 7, 2019
be19cc5
feat(aws-codepipeline): Jenkins build and test Actions. (#1216)
skinny85 Jan 7, 2019
81a5a07
feat(route53): support CNAME records (#1487)
Jan 8, 2019
ed5a38b
feat: no more generated attribute types in CFN layer (L1) (#1489)
Jan 8, 2019
ccd01e2
feat: stop generating legacy cloudformation resources (#1493)
Jan 8, 2019
b1f5b2e
feat: cloudformation condition chaining (#1494)
Jan 8, 2019
9cb842f
feat(step-functions): support parameters option (#1492)
guisrx Jan 8, 2019
f393a26
feat(cdk): transparently use constructs from another stack
rix0rrr Jan 9, 2019
6ad8c5e
fix(lambda): use IRole instead of Role to allow imports (#1509)
Jan 10, 2019
0fb62c8
fix(core): automatic cross-stack refs for CFN resources (#1510)
Jan 10, 2019
3961ad7
feat(aws-cdk): better stack dependency handling (#1511)
rix0rrr Jan 10, 2019
01d72cf
v0.22.0 (#1518)
Jan 11, 2019
948b5df
add packages.txt to github pages (#1520)
Jan 11, 2019
4443d5c
chore(scripts): Add Jetbrains node_modules exclusion script (#1507)
costleya Jan 13, 2019
582c8b1
feat(ecs): environment variables for LoadBalancedXxxService (#1537)
PaulMaddox Jan 14, 2019
c79d234
chore(cdk): make `isInstance` static methods more concrete (#1519)
rix0rrr Jan 14, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
63 changes: 63 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,69 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

## [0.22.0](https://github.com/awslabs/aws-cdk/compare/v0.21.0...v0.22.0) (2019-01-10)

This is a major release with multiple breaking changes in the core layers.
Please consult the __breaking changes__ section below for details.

We are focusing these days on finalizing the common patterns and APIs of the CDK
framework and the AWS Construct Library, which is why you are seeing all these
breaking changes. Expect a few more releases with changes of that nature as we
stabilize these APIs, so you might want to hold off with upgrading. We will
communicate when this foundational work is complete.

### Bug Fixes

* **core:** automatic cross-stack refs for CFN resources ([#1510](https://github.com/awslabs/aws-cdk/issues/1510)) ([ca5ee35](https://github.com/awslabs/aws-cdk/commit/ca5ee35))
* **ecs:** correct typo and other minor mistakes in ecs readme ([#1448](https://github.com/awslabs/aws-cdk/issues/1448)) ([9c91b20](https://github.com/awslabs/aws-cdk/commit/9c91b20))
* **elbv2:** unable to specify load balancer name ([#1486](https://github.com/awslabs/aws-cdk/issues/1486)) ([5b24583](https://github.com/awslabs/aws-cdk/commit/5b24583)), closes [#973](https://github.com/awslabs/aws-cdk/issues/973) [#1481](https://github.com/awslabs/aws-cdk/issues/1481)
* **lambda:** use IRole instead of Role to allow imports ([#1509](https://github.com/awslabs/aws-cdk/issues/1509)) ([b909dcd](https://github.com/awslabs/aws-cdk/commit/b909dcd))
* **toolkit:** fix typo in --rename option description ([#1438](https://github.com/awslabs/aws-cdk/issues/1438)) ([1dd56d4](https://github.com/awslabs/aws-cdk/commit/1dd56d4))
* **toolkit:** support multiple toolkit stacks in the same environment ([#1427](https://github.com/awslabs/aws-cdk/issues/1427)) ([095da14](https://github.com/awslabs/aws-cdk/commit/095da14)), closes [#1416](https://github.com/awslabs/aws-cdk/issues/1416)

### Features

* **apigateway:** add tracingEnabled property to APIGW Stage ([#1482](https://github.com/awslabs/aws-cdk/issues/1482)) ([fefa764](https://github.com/awslabs/aws-cdk/commit/fefa764))
* **assets:** enable local tooling scenarios such as lambda debugging ([#1433](https://github.com/awslabs/aws-cdk/issues/1433)) ([0d2b633](https://github.com/awslabs/aws-cdk/commit/0d2b633)), closes [#1432](https://github.com/awslabs/aws-cdk/issues/1432)
* **aws-cdk:** better stack dependency handling ([#1511](https://github.com/awslabs/aws-cdk/issues/1511)) ([b4bbaf0](https://github.com/awslabs/aws-cdk/commit/b4bbaf0)), closes [#1508](https://github.com/awslabs/aws-cdk/issues/1508) [#1505](https://github.com/awslabs/aws-cdk/issues/1505)
* **aws-codepipeline:** jenkins build and test actions ([#1216](https://github.com/awslabs/aws-cdk/issues/1216)) ([471e8eb](https://github.com/awslabs/aws-cdk/commit/471e8eb))
* **aws-codepipeline:** support notifications on the ManualApprovalAction ([#1368](https://github.com/awslabs/aws-cdk/issues/1368)) ([068fa46](https://github.com/awslabs/aws-cdk/commit/068fa46)), closes [#1222](https://github.com/awslabs/aws-cdk/issues/1222)
* **aws-ecs:** add support Amazon Linux 2 ([#1484](https://github.com/awslabs/aws-cdk/issues/1484)) ([82ec0ff](https://github.com/awslabs/aws-cdk/commit/82ec0ff)), closes [#1483](https://github.com/awslabs/aws-cdk/issues/1483)
* **aws-kms:** allow tagging kms keys ([#1485](https://github.com/awslabs/aws-cdk/issues/1485)) ([f43b4d4](https://github.com/awslabs/aws-cdk/commit/f43b4d4))
* **aws-lambda:** add input and output artifacts to the CodePipeline action ([#1390](https://github.com/awslabs/aws-cdk/issues/1390)) ([fbd7728](https://github.com/awslabs/aws-cdk/commit/fbd7728)), closes [#1384](https://github.com/awslabs/aws-cdk/issues/1384)
* **cdk:** transparently use constructs from another stack ([d7371f0](https://github.com/awslabs/aws-cdk/commit/d7371f0)), closes [#1324](https://github.com/awslabs/aws-cdk/issues/1324)
* **cli:** allow specifying options using env vars ([#1447](https://github.com/awslabs/aws-cdk/issues/1447)) ([7cd84a0](https://github.com/awslabs/aws-cdk/commit/7cd84a0))
* aws resource api linting (breaking changes) ([#1434](https://github.com/awslabs/aws-cdk/issues/1434)) ([8c17ca7](https://github.com/awslabs/aws-cdk/commit/8c17ca7)), closes [#742](https://github.com/awslabs/aws-cdk/issues/742) [#1428](https://github.com/awslabs/aws-cdk/issues/1428)
* **core:** cloudformation condition chaining ([#1494](https://github.com/awslabs/aws-cdk/issues/1494)) ([2169015](https://github.com/awslabs/aws-cdk/commit/2169015)), closes [#1457](https://github.com/awslabs/aws-cdk/issues/1457)
* **diff:** better diff of arbitrary json objects ([#1488](https://github.com/awslabs/aws-cdk/issues/1488)) ([607f997](https://github.com/awslabs/aws-cdk/commit/607f997))
* **route53:** support cname records ([#1487](https://github.com/awslabs/aws-cdk/issues/1487)) ([17eddd1](https://github.com/awslabs/aws-cdk/commit/17eddd1)), closes [#1420](https://github.com/awslabs/aws-cdk/issues/1420)
* **step-functions:** support parameters option ([#1492](https://github.com/awslabs/aws-cdk/issues/1492)) ([935054a](https://github.com/awslabs/aws-cdk/commit/935054a)), closes [#1480](https://github.com/awslabs/aws-cdk/issues/1480)
* **core:** construct base class changes (breaking) ([#1444](https://github.com/awslabs/aws-cdk/issues/1444)) ([fb22a32](https://github.com/awslabs/aws-cdk/commit/fb22a32)), closes [#1431](https://github.com/awslabs/aws-cdk/issues/1431) [#1441](https://github.com/awslabs/aws-cdk/issues/1441) [#189](https://github.com/awslabs/aws-cdk/issues/189) [#1441](https://github.com/awslabs/aws-cdk/issues/1441) [#1431](https://github.com/awslabs/aws-cdk/issues/1431)
* **core:** idiomize cloudformation intrinsics functions ([#1428](https://github.com/awslabs/aws-cdk/issues/1428)) ([04217a5](https://github.com/awslabs/aws-cdk/commit/04217a5)), closes [#202](https://github.com/awslabs/aws-cdk/issues/202)
* **cloudformation:** no more generated attribute types in CFN layer (L1) ([#1489](https://github.com/awslabs/aws-cdk/issues/1489)) ([4d6d5ca](https://github.com/awslabs/aws-cdk/commit/4d6d5ca)), closes [#1455](https://github.com/awslabs/aws-cdk/issues/1455) [#1406](https://github.com/awslabs/aws-cdk/issues/1406)
* **cloudformation:** stop generating legacy cloudformation resources ([#1493](https://github.com/awslabs/aws-cdk/issues/1493)) ([81b4174](https://github.com/awslabs/aws-cdk/commit/81b4174))


### BREAKING CHANGES

* **Cross-stack references:** if you are using `export()` and `import()` to share constructs between stacks, you can stop doing that, instead of `FooImportProps` accept an `IFoo` directly on the consuming stack, and use that object as usual.
* `ArnUtils.fromComponents()` and `ArnUtils.parse()` have been moved onto `Stack`.
* All CloudFormation pseudo-parameter (such as `AWS::AccountId` etc) are now also accessible via `Stack`, as `stack.accountId` etc.
* All CloudFormation intrinsic functions are now represented as static methods under the `Fn` class (e.g. `Fn.join(...)` instead of `new FnJoin(...).toString()`)
* `resolve()` has been moved to `this.node.resolve()`.
* `CloudFormationJSON.stringify()` has been moved to `this.node.stringifyJson()`. `validate()` now should be `protected`.
* The deprecated `cloudformation.XxxResource` classes have been removed. Use the `CfnXxx` classes instead.
* Any `CfnXxx` resource attributes that represented a list of strings are now typed as `string[]`s (via #1144). Attributes that represent strings, are still typed as `string` (#712) and all other attribute types are represented as `cdk.Token`.
* **route53:** The `route53.TXTRecord` class was renamed to `route53.TxtRecord`.
* **route53:** record classes now require a `zone` when created (not assuming zone is the parent construct).
* **lambda:** the static "metric" methods moved from `lambda.FunctionRef` to `lambda.Function`.
* Many AWS resource classes have been changed to conform to API guidelines:
- `XxxRef` abstract classes are now `IXxx` interfaces
- `XxxRefProps` are now `XxxImportProps`
- `XxxRef.import(...)` are now `Xxx.import(...)` accept `XxxImportProps` and return `IXxx`
- `export(): XxxImportProps` is now defined in `IXxx` and implemented by imported resources


# [0.21.0](https://github.com/awslabs/aws-cdk/compare/v0.20.0...v0.21.0) (2018-12-20)


Expand Down
23 changes: 23 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,22 @@ Here are a few useful commands:
evaluate only the rule specified [awslint README](./tools/awslint/README.md)
for details on include/exclude rule patterns.

### cfn2ts

This tool is used to generate our low-level CloudFormation resources
(L1/`CfnFoo`). It is executed as part of the build step of all modules in the
AWS Construct Library.

The tool consults the `cdk-build.cloudformation` key in `package.json` to
determine which CloudFormation namespace this library represents (e.g.
`AWS::EC2` is the namespace for `aws-ec2`). We maintain strict 1:1 relationship
between those.

Each module also has an npm script called `cfn2ts`:

* `npm run cfn2ts`: generates L1 for a specific module
* `lerna run cfn2ts`: generates L1 for the entire repo

## Development Workflows

### Full clean build
Expand Down Expand Up @@ -249,6 +265,13 @@ $ cd docs
$ BUILD_DOCS_DEV=1 ./build-docs.sh
```

### Tooling Assists
#### Jetbrains (WebStorm/IntelliJ)
This project uses lerna and utilizes symlinks inside nested node_modules directories. You may encounter an issue during
indexing where the IDE attempts to index these directories and keeps following links until the process runs out of
available memory and crashes. To fix this, you can run ```node ./scripts/jetbrains-remove-node-modules.js``` to exclude
these directories.

## Dependencies

### Adding Dependencies
Expand Down
2 changes: 2 additions & 0 deletions build-docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ set -euo pipefail
# render docs to docs/dist
(cd docs && bash ./build-docs.sh)

lerna ls > docs/dist/packages.txt

# deploy output to 'pack/docs'
rm -fr dist/docs
mkdir dist/docs
Expand Down
2 changes: 1 addition & 1 deletion design/aws-guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ properties that allow the user to specify an external resource identity, usually
by providing one or more resource attributes such as ARN, physical name, etc.

The import interface should have the minimum required properties, that is: if it
is possible to parse the resource name from the ARN (using `cdk.ArnUtils.parse`),
is possible to parse the resource name from the ARN (using `cdk.Stack.parseArn`),
then only the ARN should be required. In cases where it
is not possible to parse the ARN (e.g. if it is a token and the resource name
might have use "/" characters), both the ARN and the name should be optional and
Expand Down
15 changes: 13 additions & 2 deletions docs/src/cloudformation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -149,18 +149,29 @@ Outputs
Conditions
----------
.. NEEDS SOME INTRO TEXT
`cdk.Condition` can be used to define CloudFormation "Condition" elements in the template.
The `cdk.Fn.conditionXx()` static methods can be used to produce "condition expressions".
.. code-block:: js
import sqs = require('@aws-cdk/aws-sqs');
import cdk = require('@aws-cdk/cdk');
const param = new cdk.Parameter(this, 'Param1', { type: 'String' });
const cond1 = new cdk.Condition(this, 'Condition1', { expression: cdk.Fn.conditionEquals("a", "b") });
const cond2 = new cdk.Condition(this, 'Condition2', { expression: cdk.Fn.conditionContains([ "a", "b", "c" ], "c") });
const cond3 = new cdk.Condition(this, 'Condition3', { expression: cdk.Fn.conditionEquals(param, "hello") });
const cond4 = new cdk.Condition(this, 'Condition4', {
expression: cdk.Fn.conditionOr(cond1, cond2, cdk.Fn.conditionNot(cond3))
});
const cond = new cdk.Condition(this, 'MyCondition', {
expression: new cdk.FnIf(...)
});
const queue = new sqs.CfnQueue(this, 'MyQueue');
queue.options.condition = cond;
queue.options.condition = cond4;
.. _intrinsic_functions:
Expand Down
6 changes: 3 additions & 3 deletions examples/cdk-examples-java/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cdk-examples-java",
"version": "0.21.0",
"version": "0.22.0",
"description": "CDK examples in Java",
"private": true,
"repository": {
Expand All @@ -22,7 +22,7 @@
},
"license": "Apache-2.0",
"devDependencies": {
"aws-cdk": "^0.21.0",
"pkgtools": "^0.21.0"
"aws-cdk": "^0.22.0",
"pkgtools": "^0.22.0"
}
}
17 changes: 8 additions & 9 deletions examples/cdk-examples-typescript/advanced-usage/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ class CloudFormationExample extends cdk.Stack {
// outputs are constructs the synthesize into the template's "Outputs" section
new cdk.Output(this, 'Output', {
description: 'This is an output of the template',
value: `${new cdk.AwsAccountId()}/${param.ref}`
value: `${this.accountId}/${param.ref}`
});

// stack.templateOptions can be used to specify template-level options
Expand All @@ -166,14 +166,13 @@ class CloudFormationExample extends cdk.Stack {

// all CloudFormation's pseudo-parameters are supported via the `cdk.AwsXxx` classes
PseudoParameters: [
new cdk.AwsAccountId(),
new cdk.AwsDomainSuffix(),
new cdk.AwsNotificationARNs(),
new cdk.AwsNoValue(),
new cdk.AwsPartition(),
new cdk.AwsRegion(),
new cdk.AwsStackId(),
new cdk.AwsStackName(),
this.accountId,
this.urlSuffix,
this.notificationArns,
this.partition,
this.region,
this.stackId,
this.stackName,
],

// all CloudFormation's intrinsic functions are supported via the `cdk.Fn.xxx` static methods.
Expand Down
42 changes: 21 additions & 21 deletions examples/cdk-examples-typescript/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cdk-examples-typescript",
"version": "0.21.0",
"version": "0.22.0",
"description": "A bunch of CDK examples",
"private": true,
"scripts": {
Expand All @@ -18,28 +18,28 @@
},
"license": "Apache-2.0",
"devDependencies": {
"aws-cdk": "^0.21.0",
"cdk-build-tools": "^0.21.0",
"pkglint": "^0.21.0"
"aws-cdk": "^0.22.0",
"cdk-build-tools": "^0.22.0",
"pkglint": "^0.22.0"
},
"dependencies": {
"@aws-cdk/aws-autoscaling": "^0.21.0",
"@aws-cdk/aws-cloudformation": "^0.21.0",
"@aws-cdk/aws-cognito": "^0.21.0",
"@aws-cdk/aws-dynamodb": "^0.21.0",
"@aws-cdk/aws-ec2": "^0.21.0",
"@aws-cdk/aws-ecs": "^0.21.0",
"@aws-cdk/aws-elasticloadbalancing": "^0.21.0",
"@aws-cdk/aws-elasticloadbalancingv2": "^0.21.0",
"@aws-cdk/aws-iam": "^0.21.0",
"@aws-cdk/aws-lambda": "^0.21.0",
"@aws-cdk/aws-neptune": "^0.21.0",
"@aws-cdk/aws-rds": "^0.21.0",
"@aws-cdk/aws-s3": "^0.21.0",
"@aws-cdk/aws-sns": "^0.21.0",
"@aws-cdk/aws-sqs": "^0.21.0",
"@aws-cdk/cdk": "^0.21.0",
"@aws-cdk/runtime-values": "^0.21.0"
"@aws-cdk/aws-autoscaling": "^0.22.0",
"@aws-cdk/aws-cloudformation": "^0.22.0",
"@aws-cdk/aws-cognito": "^0.22.0",
"@aws-cdk/aws-dynamodb": "^0.22.0",
"@aws-cdk/aws-ec2": "^0.22.0",
"@aws-cdk/aws-ecs": "^0.22.0",
"@aws-cdk/aws-elasticloadbalancing": "^0.22.0",
"@aws-cdk/aws-elasticloadbalancingv2": "^0.22.0",
"@aws-cdk/aws-iam": "^0.22.0",
"@aws-cdk/aws-lambda": "^0.22.0",
"@aws-cdk/aws-neptune": "^0.22.0",
"@aws-cdk/aws-rds": "^0.22.0",
"@aws-cdk/aws-s3": "^0.22.0",
"@aws-cdk/aws-sns": "^0.22.0",
"@aws-cdk/aws-sqs": "^0.22.0",
"@aws-cdk/cdk": "^0.22.0",
"@aws-cdk/runtime-values": "^0.22.0"
},
"repository": {
"url": "https://github.com/awslabs/aws-cdk.git",
Expand Down
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@
}
},
"rejectCycles": "true",
"version": "0.21.0"
"version": "0.22.0"
}
19 changes: 10 additions & 9 deletions packages/@aws-cdk/alexa-ask/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@aws-cdk/alexa-ask",
"version": "0.21.0",
"version": "0.22.0",
"description": "The CDK Construct Library for Alexa::ASK",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down Expand Up @@ -36,7 +36,8 @@
"pkglint": "pkglint -f",
"test": "cdk-test",
"watch": "cdk-watch",
"awslint": "cdk-awslint"
"awslint": "cdk-awslint",
"cfn2ts": "cfn2ts"
},
"cdk-build": {
"cloudformation": "Alexa::ASK"
Expand All @@ -54,18 +55,18 @@
},
"license": "Apache-2.0",
"devDependencies": {
"@aws-cdk/assert": "^0.21.0",
"cdk-build-tools": "^0.21.0",
"cfn2ts": "^0.21.0",
"pkglint": "^0.21.0"
"@aws-cdk/assert": "^0.22.0",
"cdk-build-tools": "^0.22.0",
"cfn2ts": "^0.22.0",
"pkglint": "^0.22.0"
},
"dependencies": {
"@aws-cdk/cdk": "^0.21.0"
"@aws-cdk/cdk": "^0.22.0"
},
"peerDependencies": {
"@aws-cdk/cdk": "^0.21.0"
"@aws-cdk/cdk": "^0.22.0"
},
"engines": {
"node": ">= 8.10.0"
}
}
}
20 changes: 10 additions & 10 deletions packages/@aws-cdk/app-delivery/lib/pipeline-deploy-stack-action.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,16 +140,6 @@ export class PipelineDeployStackAction extends cdk.Construct {
});
}

public validate(): string[] {
const result = super.validate();
const assets = this.stack.node.metadata.filter(md => md.type === cxapi.ASSET_METADATA);
if (assets.length > 0) {
// FIXME: Implement the necessary actions to publish assets
result.push(`Cannot deploy the stack ${this.stack.name} because it references ${assets.length} asset(s)`);
}
return result;
}

/**
* Add policy statements to the role deploying the stack.
*
Expand All @@ -162,6 +152,16 @@ export class PipelineDeployStackAction extends cdk.Construct {
public addToRolePolicy(statement: iam.PolicyStatement) {
this.role.addToPolicy(statement);
}

protected validate(): string[] {
const result = super.validate();
const assets = this.stack.node.metadata.filter(md => md.type === cxapi.ASSET_METADATA);
if (assets.length > 0) {
// FIXME: Implement the necessary actions to publish assets
result.push(`Cannot deploy the stack ${this.stack.name} because it references ${assets.length} asset(s)`);
}
return result;
}
}

function cfnCapabilities(adminPermissions: boolean, capabilities?: cfn.CloudFormationCapabilities): cfn.CloudFormationCapabilities {
Expand Down
Loading