Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cognito): add support for token revocation in UserPoolClient #15317

Merged
merged 8 commits into from
Aug 10, 2021

Conversation

jumic
Copy link
Contributor

@jumic jumic commented Jun 25, 2021

Add support for token revocation in UserPoolClient.

For new user pool clients, token revocation is enabled by default. Property enableTokenRevocation introduces the possibility to enable token revocation for existing user pool clients.

Closes #15126


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 25, 2021

peterwoodworth
peterwoodworth previously approved these changes Jul 7, 2021
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the contribution!

@mergify mergify bot dismissed peterwoodworth’s stale review July 9, 2021 21:32

Pull request has been modified.

@jumic
Copy link
Contributor Author

jumic commented Jul 10, 2021

@peterwoodworth Thank you for approving this PR. 👍 Because of the missing description in the readme, I hat to change the PR. Could you please review it again?

@peterwoodworth
Copy link
Contributor

Thanks for the additional readme comment 😄

Could you add one more test which ensures you can set this variable through the L2 construct UserPoolClient rather than just the addClient() method?

@peterwoodworth peterwoodworth self-assigned this Jul 12, 2021
@jumic
Copy link
Contributor Author

jumic commented Jul 15, 2021

Additional test is added as requested. (Not sure if this comment is necessary to mark this change as done).

@jumic jumic requested a review from peterwoodworth July 23, 2021 22:29
peterwoodworth
peterwoodworth previously approved these changes Aug 6, 2021
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed peterwoodworth’s stale review August 7, 2021 11:58

Pull request has been modified.

@jumic
Copy link
Contributor Author

jumic commented Aug 7, 2021

The build failed after the current master branch was merged to this branch. Class TemplateAssertions was renamed to Template. I corrected the name in the test cases of this PR.
Could you please review the changes again? Thanks.

Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here, and thank you for the contribution 🙏

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9e29720
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8cb0e97 into aws:master Aug 10, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…s#15317)

Add support for token revocation in UserPoolClient.

For new user pool clients, token revocation is enabled by default. Property `enableTokenRevocation` introduces the possibility to enable token revocation for existing user pool clients.

Closes aws#15126

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
…s#15317)

Add support for token revocation in UserPoolClient.

For new user pool clients, token revocation is enabled by default. Property `enableTokenRevocation` introduces the possibility to enable token revocation for existing user pool clients.

Closes aws#15126

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cognito: support token revokation
3 participants