-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cognito): add support for token revocation in UserPoolClient #15317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for the contribution!
Pull request has been modified.
@peterwoodworth Thank you for approving this PR. 👍 Because of the missing description in the readme, I hat to change the PR. Could you please review it again? |
Thanks for the additional readme comment 😄 Could you add one more test which ensures you can set this variable through the L2 construct |
Additional test is added as requested. (Not sure if this comment is necessary to mark this change as done). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
The build failed after the current master branch was merged to this branch. Class TemplateAssertions was renamed to Template. I corrected the name in the test cases of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay here, and thank you for the contribution 🙏
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…s#15317) Add support for token revocation in UserPoolClient. For new user pool clients, token revocation is enabled by default. Property `enableTokenRevocation` introduces the possibility to enable token revocation for existing user pool clients. Closes aws#15126 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…s#15317) Add support for token revocation in UserPoolClient. For new user pool clients, token revocation is enabled by default. Property `enableTokenRevocation` introduces the possibility to enable token revocation for existing user pool clients. Closes aws#15126 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add support for token revocation in UserPoolClient.
For new user pool clients, token revocation is enabled by default. Property
enableTokenRevocation
introduces the possibility to enable token revocation for existing user pool clients.Closes #15126
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license