Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aws-ecr-assets): Update link for cdk-ecr-deployment repo #15407

Merged
merged 4 commits into from
Jul 7, 2021
Merged

docs(aws-ecr-assets): Update link for cdk-ecr-deployment repo #15407

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ff7568
Update README.md
antonioortegajr Jul 2, 2021
5ea535e
Update README.md
antonioortegajr Jul 2, 2021
3636d65
Merge branch 'master' into master
antonioortegajr Jul 2, 2021
cdfd93a
Merge branch 'master' into master
mergify[bot] Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/@aws-cdk/aws-ecr-assets/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ The mechanics of where these images are published and how are intentionally kept
does not support customizations such as specifying the ECR repository name or tags.

If you are looking for a way to _publish_ image assets to an ECR repository in your control, you should consider using
[wchaws/cdk-ecr-deployment], which is able to replicate an image asset from the CDK-controlled ECR repository to a repository of
[cdklabs/cdk-ecr-deployment], which is able to replicate an image asset from the CDK-controlled ECR repository to a repository of
your choice.

Here an example from the [wchaws/cdk-ecr-deployment] project:
Here an example from the [cdklabs/cdk-ecr-deployment] project:

```ts
import * as ecrdeploy from 'cdk-ecr-deployment';
Expand All @@ -99,7 +99,7 @@ new ecrdeploy.ECRDeployment(this, 'DeployDockerImage', {
You are welcome to +1 [this GitHub issue](https://github.com/aws/aws-cdk/issues/12597) if you would like to see
native support for this use-case in the AWS CDK.

[wchaws/cdk-ecr-deployment]: https://github.com/wchaws/cdk-ecr-deployment
[cdklabs/cdk-ecr-deployment]: https://github.com/cdklabs/cdk-ecr-deployment

## Pull Permissions

Expand Down