Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api-gateway): Fix IAM policy Effect enum case #15417

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

benmunro
Copy link
Contributor

@benmunro benmunro commented Jul 5, 2021

The Effect enum values were changed to be upper case in #2918 (b735d1c) but this usage in the docs was missed


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 5, 2021

@benmunro benmunro changed the title docs(api-gateway) Fix IAM policy Effect enum case docs(api-gateway): Fix IAM policy Effect enum case Jul 5, 2021
The Effect enum values were changed to be upper case in aws#2918 (b735d1c) but this usage in the docs was missed
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this and submitting it! The contribution is appreciated 😄

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: cdf53c7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c37c7f9 into aws:master Jul 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

upparekh pushed a commit to upparekh/aws-cdk that referenced this pull request Jul 8, 2021
The Effect enum values were changed to be upper case in aws#2918 (b735d1c) but this usage in the docs was missed


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
The Effect enum values were changed to be upper case in aws#2918 (b735d1c) but this usage in the docs was missed


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants