Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(appmesh): Suggest improvements for App Mesh readme #15506

Merged
merged 11 commits into from Jul 21, 2021
Merged

docs(appmesh): Suggest improvements for App Mesh readme #15506

merged 11 commits into from Jul 21, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 11, 2021

Did a quick review of this README and made some generally minor suggestions.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 11, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 11, 2021
@Seiya6329
Copy link
Contributor

Thanks @jerry-aws for review the README!

@skinny85
Copy link
Contributor

@dfezzie would you mind reviewing this PR? Thanks!

@Seiya6329
Copy link
Contributor

@jerry-aws - Would it be easier for you if I submit separate PR based on your change since there is a merge conflict?

@ghost
Copy link
Author

ghost commented Jul 16, 2021

@Seiya6329 fixed merge conflicts.

packages/@aws-cdk/aws-appmesh/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-appmesh/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-appmesh/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-appmesh/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-appmesh/README.md Outdated Show resolved Hide resolved
@Seiya6329
Copy link
Contributor

@jerry-aws - Thanks for the review. It is looking great and much easier to read. I have minor comments.

Jerry Kindall and others added 5 commits July 21, 2021 11:04
Co-authored-by: Seiya6329 <seiyatajima6329@gmail.com>
Co-authored-by: Seiya6329 <seiyatajima6329@gmail.com>
Co-authored-by: Seiya6329 <seiyatajima6329@gmail.com>
Co-authored-by: Seiya6329 <seiyatajima6329@gmail.com>
@ghost
Copy link
Author

ghost commented Jul 21, 2021

@Seiya6329 Accepted those changes; this should be good to go.

@Seiya6329
Copy link
Contributor

@ghost
Copy link
Author

ghost commented Jul 21, 2021

@Seiya6329 No, unintentional. I'll restore those changes.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 1fe42d7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ghost
Copy link
Author

ghost commented Jul 21, 2021

@Seiya6329 The inadvertent reversions have been addressed and it's building now. Should be good to go!

@Seiya6329
Copy link
Contributor

@jerry-aws Looks great! Thank you very much!

@Seiya6329
Copy link
Contributor

@skinny85 I reviewed the change and it looks good. Could you approve it to merge?

@mergify mergify bot merged commit 56f3275 into aws:master Jul 21, 2021
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
Did a quick review of this README and made some generally minor suggestions.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Did a quick review of this README and made some generally minor suggestions.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants