Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apigatewayv2): some methods of the defaultStage are not available without casting it to IHttpStage #15607

Merged
merged 2 commits into from Sep 3, 2021
Merged

fix(apigatewayv2): some methods of the defaultStage are not available without casting it to IHttpStage #15607

merged 2 commits into from Sep 3, 2021
+3 −3

Conversation

ghost
Copy link

@ghost ghost commented Jul 16, 2021 •
edited by ghost
Loading

Closes #14787. Changes the defaultStage to an IHttpStage.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 16, 2021

@mergify
Copy link
Contributor

mergify bot commented Jul 16, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@ghost ghost changed the title (fix): change the defaultStage to an IHttpStage fix(apigatewayv2): change the defaultStage to an IHttpStage Jul 16, 2021
@nija-at nija-at added the pr-linter/exempt-test The PR linter will not require test changes label Jul 19, 2021
nija-at
nija-at reviewed Jul 19, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The title of a 'fix' PR should summarize the bug it's fixing, and not the solution.

We auto generate our changelog from our commit titles. Since this is marked as a 'fix', it will show up under the 'bug fixes' section. The commit title will show up as the bug that was fixed. So the title needs to match to that appropriately.

The details of the solution should be in the description.

@ghost ghost changed the title fix(apigatewayv2): change the defaultStage to an IHttpStage fix(apigatewayv2): some methods of the defaultStage are not available without casting it to IHttpStage Jul 19, 2021
@peterwoodworth peterwoodworth added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label Jul 20, 2021
nija-at
nija-at suggested changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting to 'request changes'

@nija-at nija-at assigned ghost and unassigned nija-at Aug 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c7a9327
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 27a0113 into aws:master Sep 3, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
@TikiTDO
fix(apigatewayv2): some methods of the defaultStage are not availab…
091b248 
…le without casting it to `IHttpStage` (aws#15607)

----

Closes aws#14787. Changes the defaultStage to an IHttpStage.

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
@david-doyle-as24
fix(apigatewayv2): some methods of the defaultStage are not availab…
77d5b75 
…le without casting it to `IHttpStage` (aws#15607)

----

Closes aws#14787. Changes the defaultStage to an IHttpStage.

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(apigatewayv2): Change defaultStage to an IHttpStage
4 participants
@aws-cdk-automation @nija-at @peterwoodworth @comcalvi