Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow asset bundling when selinux is enabled #15742

Merged
merged 4 commits into from
Sep 2, 2021
Merged

fix(core): allow asset bundling when selinux is enabled #15742

merged 4 commits into from
Sep 2, 2021

Conversation

maafk
Copy link
Contributor

@maafk maafk commented Jul 24, 2021


Revisiting #9445 but looking to see if running on linux with selinux enabled.

This PR aims to allow for asset bundling on linux os with selinux enabled

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 24, 2021

@maafk
Copy link
Contributor Author

maafk commented Jul 24, 2021

Since the idea here is to work seamlessly when bundling on linux with selinux enabled, users shouldn't need to know/care about this, so I think the pr-linter/exempt-readme label is appropriate.

Thanks!

@peterwoodworth peterwoodworth added the @aws-cdk/core Related to core CDK functionality label Jul 28, 2021
@nija-at nija-at added effort/small Small work item – less than a day of effort p2 labels Aug 5, 2021
@peterwoodworth peterwoodworth added p1 and removed p2 labels Aug 13, 2021
@rix0rrr rix0rrr changed the title feat(core): allow asset bundling when selinux is enabled fix(core): allow asset bundling when selinux is enabled Sep 2, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 1341f8f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit dbfebb4 into aws:master Sep 2, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@maafk maafk deleted the selinux-docker-mount branch September 2, 2021 10:52
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
----

Revisiting [aws#9445](aws#9445) but looking to see if running on linux with selinux enabled.

This PR aims to allow for asset bundling on linux os with selinux enabled

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
----

Revisiting [aws#9445](aws#9445) but looking to see if running on linux with selinux enabled.

This PR aims to allow for asset bundling on linux os with selinux enabled

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants