feat(cloudwatch): add verticalAnnotations property to GraphWidget #15809
Conversation
|
|
|
Just realized there are breaking changes here - interface Should I revert |
brendo-m
force-pushed
the
vertical-annotation
branch
from
bc433b3 to
c8d9eee
Compare
|
I just went ahead and made that change |
RomainMuller
force-pushed
the
master
branch
from
924c117 to
ebfd5f2
Compare
|
@RomainMuller any chance of this to get merged? |
There was a problem hiding this comment.
Thank you for your contribution, @brendo-m! We just need a description and an example added to the README before this can be merged.
| const verticalAnnotations = this.props.verticalAnnotations; | ||
| const annotations = horizontalAnnotations.length > 0 || verticalAnnotations ? ({ | ||
| horizontal: horizontalAnnotations.length > 0 ? horizontalAnnotations : undefined, | ||
| vertical: verticalAnnotations, | ||
| }) : undefined; |
There was a problem hiding this comment.
Should we check for verticalAnnotations.length > 0 ?
madeline-k
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This PR has been deemed to be abandoned, and will be closed. Please create a new PR for these changes if you think this decision has been made in error. |
|
Reviving this PR in #22568 |
Adds a
verticalAnnotationproperty toGraphWidget. See https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/CloudWatch-Dashboard-Body-Structure.html#CloudWatch-Dashboard-Properties-Annotation-Format.Also see #7622
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license