Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(assertions): explicit feature flags to produce a consistent template during tests #15924

Merged
merged 2 commits into from
Aug 6, 2021
Merged

chore(assertions): explicit feature flags to produce a consistent template during tests #15924

merged 2 commits into from
Aug 6, 2021

Conversation

otaviomacedo
Copy link
Contributor

@otaviomacedo otaviomacedo commented Aug 6, 2021

In v1, the default value of the @aws-cdk/core:newStyleStackSynthesis flag is false. As a consequence, Template.fromStack() generates, by default, a template without the rule and parameter related to bootstrap versions. In v2, the default value of this flag is true. So this test fails in the v2 branch. By explicitly setting the flag to false, we ensure that the tests passes on both v1 and v2, regardless of the default values.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…sure that the generated stack has no bootstrap elements
@gitpod-io
Copy link

gitpod-io bot commented Aug 6, 2021

@otaviomacedo otaviomacedo requested a review from nija-at August 6, 2021 13:33
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 6, 2021
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a little more context and explanation of the fix in the PR description?

Think of someone looking at this commit 3 months later, trying to see why this flag was added. The description should make enough sense to them.

@nija-at nija-at changed the title chore(assertions): setting newStyleStackSynthesis to false to make sure that the generated stack has no bootstrap elements chore(assertions): explicit feature flags to produce a consistent template Aug 6, 2021
@nija-at nija-at changed the title chore(assertions): explicit feature flags to produce a consistent template chore(assertions): explicit feature flags to produce a consistent template during tests Aug 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 7be3eda
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4ce3182 into aws:master Aug 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…plate during tests (aws#15924)

In v1, the default value of the `@aws-cdk/core:newStyleStackSynthesis` flag is `false`. As a consequence, `Template.fromStack()` generates, by default, a template without the rule and parameter related to bootstrap versions. In v2,  the default value of this flag is `true`. So this test fails in the v2 branch. By explicitly setting the flag to `false`, we ensure that the tests passes on both v1 and v2, regardless of the default values.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
…plate during tests (aws#15924)

In v1, the default value of the `@aws-cdk/core:newStyleStackSynthesis` flag is `false`. As a consequence, `Template.fromStack()` generates, by default, a template without the rule and parameter related to bootstrap versions. In v2,  the default value of this flag is `true`. So this test fails in the v2 branch. By explicitly setting the flag to `false`, we ensure that the tests passes on both v1 and v2, regardless of the default values.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants