fix(ecs): imported services don't have account & region set correctly

[robert-lilleker]

This is a fix for the region issue raised by #11199 allowing multi regional ecs deployments

fixes #11199

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[mergify]

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

[robert-lilleker]

Is there anything I can do that might further this along?

[skinny85]

Thanks for the PR @robert-lilleker, but this is not a good solution - the region the EcsDeployAction is taken from the service that is passed to it, it can't be set separately from that.

The correct fix to take the region (and account) of the service from the ARN when it's imported using the fromEc2ServiceAttributes() / fromFargateServiceAttributes() methods. This needs a change here, basically changing this line:

  return new Import(scope, id);

to:

  return new Import(scope, id, {
    environmentFromArn: arn,
  });

All of the other changes in this PR should be reverted.

Thanks,
Adam

[skinny85]

Changes to this file should be reverted.

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: f3b76d9
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[skinny85]

Awesome work @robert-lilleker, but we also need a unit test 🙂. Take some inspiration from these.

[TheRealAmazonKendra]

This issue was fixed by #16997.