feat(elasticloadbalancingv2): ALPN policy support for NLB listener #15956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
project0
changed the title
project0
changed the title
project0
changed the title
project0
force-pushed
the
elbv2/add-alpn-support
branch
from
8b651d2 to
19e6b01
Compare
peterwoodworth
added
the
@aws-cdk/aws-elasticloadbalancingv2
project0
commented
Aug 13, 2021
| @@ -168,12 +179,17 @@ export class NetworkListener extends BaseListener implements INetworkListener { | |||
| throw new Error('Protocol must be TLS when certificates have been specified'); | |||
| } | |||
|
|
|||
| if (proto !== Protocol.TLS && props.alpnPolicy) { | |||
| throw new Error('Protocol must be TLS when alpnPolicy have been specified'); | |||
There was a problem hiding this comment.
Should we change this to aspect errors (i just adopted the same pattern from above)?
njlynch
changed the title
njlynch
added
the
pr-linter/exempt-readme
njlynch
previously approved these changes
Aug 27, 2021
mergify
bot
dismissed
njlynch’s stale review
Pull request has been modified.
njlynch
previously approved these changes
Sep 3, 2021
mergify
bot
dismissed
njlynch’s stale review
Pull request has been modified.
njlynch
approved these changes
Sep 3, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Sep 6, 2021
…ws#15956) Allow specifying the ALPN Policy ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
…ws#15956) Allow specifying the ALPN Policy ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying the ALPN Policy
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license