fix(lambda-python): incorrect handler name when the handler is in a subdirectory #15981
Conversation
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
peterwoodworth
added
@aws-cdk/aws-lambda-python
effort/small
nija-at
changed the title
There was a problem hiding this comment.
Thanks for submitting this PR. I just have one main comment.
I can't find any docs on how the handler name should be specified when it is in the inner directory - https://docs.aws.amazon.com/lambda/latest/dg/python-handler.html
Can you supply how you tested and confirmed that this is the correct solution, or point me to some docs?
|
@nija-at His explanation aligns with my understanding. The problem is that the Lambda function handler is imported with slashes, when dot notation is what is needed for Python imports. |
There was a problem hiding this comment.
Hi @vincent-turato -
Looks good generally. Just one comment.
| @@ -113,7 +113,7 @@ export class PythonFunction extends lambda.Function { | |||
| assetHashType: props.assetHashType, | |||
| assetHash: props.assetHash, | |||
| }), | |||
| handler: `${index.slice(0, -3)}.${handler}`, | |||
| handler: `${index.replace(/\.py$/i, '').replace('/', '.')}.${handler}`, | |||
There was a problem hiding this comment.
Can you add a little comment with a small example explaining this string replace?
RomainMuller
force-pushed
the
master
branch
from
924c117
to
ebfd5f2
Compare
|
Closing this PR since there has been no traction in a while. |
If a handler function is located in a subdirectory of the lambda code package, the aws_lambda.Function handler property would be set to an incorrect value.
Copied from: #15391
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license