Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): add m6i instances #16081

Merged
merged 9 commits into from
Aug 26, 2021
Merged

feat(ec2): add m6i instances #16081

merged 9 commits into from
Aug 26, 2021

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Aug 16, 2021

https://aws.amazon.com/about-aws/whats-new/2021/08/amazon-ec2-m6i-instances/


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 16, 2021

@peterwoodworth
Copy link
Contributor

Hey @robertd,

Do you know if these changes automatically implemented in CloudFormation? Or, have you successfully deployed a stack with an m6i instance? Thanks

@peterwoodworth peterwoodworth self-assigned this Aug 19, 2021
@peterwoodworth peterwoodworth added @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort labels Aug 19, 2021
@robertd
Copy link
Contributor Author

robertd commented Aug 20, 2021

@peterwoodworth Yeah... m6i instances are being generated properly. I guess CloudFormation docs haven't been updated yet (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype). I guess I can track down that repo and submit a PR there too.

image

ssm-user@ip-[redacted]:/var/snap/amazon-ssm-agent/4662$ lscpu
Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              2
Core(s) per socket:              1
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           106
Model name:                      Intel(R) Xeon(R) Platinum 8375C CPU @ 2.90GHz
Stepping:                        6
CPU MHz:                         3503.124
BogoMIPS:                        5799.97
Hypervisor vendor:               KVM
Virtualization type:             full
L1d cache:                       48 KiB
L1i cache:                       32 KiB
L2 cache:                        1.3 MiB
L3 cache:                        54 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     Not affected
Vulnerability L1tf:              Not affected
Vulnerability Mds:               Not affected
Vulnerability Meltdown:          Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Enhanced IBRS, IBPB conditional, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fx
                                 sr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology no
                                 nstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse
                                 4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_l
                                 m abm 3dnowprefetch invpcid_single ssbd ibrs ibpb stibp ibrs_enhanced fsgsbase tsc_adj
                                 ust bmi1 avx2 smep bmi2 erms invpcid avx512f avx512dq rdseed adx smap avx512ifma clflu
                                 shopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves wbnoinvd i
                                 da arat avx512vbmi pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bita
                                 lg avx512_vpopcntdq rdpid md_clear flush_l1d arch_capabilities

@robertd
Copy link
Contributor Author

robertd commented Aug 20, 2021

@robertd
Copy link
Contributor Author

robertd commented Aug 23, 2021

@peterwoodworth Do you think we can squeeze this in the 1.120.0 release?

@peterwoodworth peterwoodworth removed their assignment Aug 23, 2021
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the @ stability tag necessary here?

@peterwoodworth
Copy link
Contributor

Looks good to me otherwise, I'll leave to @njlynch for final review

@robertd
Copy link
Contributor Author

robertd commented Aug 23, 2021

Why is the @ stability tag necessary here?

@peterwoodworth I have no idea how that got there 😄 .... removed. Good catch.

@peterwoodworth peterwoodworth added the pr-linter/exempt-readme The PR linter will not require README changes label Aug 23, 2021
njlynch
njlynch previously approved these changes Aug 24, 2021
@mergify mergify bot dismissed njlynch’s stale review August 24, 2021 22:29

Pull request has been modified.

@robertd
Copy link
Contributor Author

robertd commented Aug 24, 2021

Whoops... You'll have to re-approve it again @njlynch. Sorry about that 😄 ... I thought I was merging-in updates from my other pending PRs. My bad 😅

@robertd robertd requested a review from peterwoodworth August 25, 2021 22:00
@robertd
Copy link
Contributor Author

robertd commented Aug 26, 2021

@njlynch @peterwoodworth Can we get this one shipped? Not sure why mergebot is not picking it up since Nick already gave his blessings. Perhaps because there are two reviewers?

@peterwoodworth peterwoodworth added the pr-linter/exempt-test The PR linter will not require test changes label Aug 26, 2021
@peterwoodworth
Copy link
Contributor

@robertd it's because there were no changes to a test file. I've handled it, it should merge soon

@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a42a1ea into aws:master Aug 26, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: fe6d5aa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@robertd robertd deleted the ec2-m6i branch August 26, 2021 20:52
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
https://aws.amazon.com/about-aws/whats-new/2021/08/amazon-ec2-m6i-instances/

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
https://aws.amazon.com/about-aws/whats-new/2021/08/amazon-ec2-m6i-instances/

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort p1 pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants