Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): unnecessary log group in Step Functions state machine x-ray example #16159

Merged
merged 4 commits into from
Aug 26, 2021

Conversation

benhawley7
Copy link
Contributor

@benhawley7 benhawley7 commented Aug 21, 2021

Removes an unnecessary log group definition from the code example for enabling X-Ray in the State Machine.

fixes #16158


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 21, 2021

BenChaimberg
BenChaimberg previously approved these changes Aug 26, 2021
@mergify mergify bot dismissed BenChaimberg’s stale review August 26, 2021 16:52

Pull request has been modified.

@BenChaimberg BenChaimberg changed the title fix(aws-stepfunctions): remove log group from x-ray example in docs fix(stepfunctions): unnecessary log group in state machine x-ray example Aug 26, 2021
@BenChaimberg BenChaimberg added @aws-cdk/aws-stepfunctions Related to AWS StepFunctions pr-linter/exempt-test The PR linter will not require test changes labels Aug 26, 2021
@BenChaimberg BenChaimberg changed the title fix(stepfunctions): unnecessary log group in state machine x-ray example fix(docs): unnecessary log group in Step Functions state machine x-ray example Aug 26, 2021
@BenChaimberg BenChaimberg added the documentation This is a problem with documentation. label Aug 26, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 4ca9454
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 04d4547 into aws:master Aug 26, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…y example (aws#16159)

Removes an unnecessary log group definition from the code example for enabling X-Ray in the State Machine.

fixes aws#16158

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
…y example (aws#16159)

Removes an unnecessary log group definition from the code example for enabling X-Ray in the State Machine.

fixes aws#16158

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
…y example (aws#16159)

Removes an unnecessary log group definition from the code example for enabling X-Ray in the State Machine.

fixes aws#16158

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions documentation This is a problem with documentation. pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-stepfunctions): unnecessary log group definition in x-ray tracing example
3 participants