Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cfnspec): changes to resource-level documentation not supported #16170

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

BenChaimberg
Copy link
Contributor

Internal reference: V417958316


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@BenChaimberg BenChaimberg requested a review from a team August 23, 2021 04:01
@gitpod-io
Copy link

gitpod-io bot commented Aug 23, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 23, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b70e69a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Aug 23, 2021
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

PR titles for 'fix' should summarize the issue being fixed rather than the resolution.

@BenChaimberg
Copy link
Contributor Author

PR titles for 'fix' should summarize the issue being fixed rather than the resolution.

Ugh, I always forget this

@BenChaimberg BenChaimberg changed the title fix(cfnspec): allow resource-level documentation changes fix(cfnspec): changes to resource-level documentation not supported Aug 23, 2021
@BenChaimberg BenChaimberg added pr-linter/exempt-test The PR linter will not require test changes and removed pr/do-not-merge This PR should not be merged at this time. labels Aug 23, 2021
@mergify mergify bot merged commit 82e4b4f into master Aug 23, 2021
@mergify mergify bot deleted the chaimber/cfnspec_diff_doc branch August 23, 2021 13:26
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…ws#16170)

Internal reference: V417958316

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
…ws#16170)

Internal reference: V417958316

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
…ws#16170)

Internal reference: V417958316

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants