Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aws-ecr-assets): Correct un-closed parenthetical expression #16172

Merged
merged 2 commits into from
Sep 1, 2021
Merged

docs(aws-ecr-assets): Correct un-closed parenthetical expression #16172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b09c20b
Correct un-closed parenthetical expression
douglasnaphas Aug 23, 2021
51fe50a
Merge branch 'master' into patch-1
mergify[bot] Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-ecr-assets/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ interpreted. The recommended setting for Docker image assets is
old projects) then `IgnoreMode.DOCKER` is the default and you don't need to
configure it on the asset itself.

Use `asset.imageUri` to reference the image (it includes both the ECR image URL
Use `asset.imageUri` to reference the image. It includes both the ECR image URL
and tag.

You can optionally pass build args to the `docker build` command by specifying
Expand Down