Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigatewayv2): ApiMapping does not depend on DomainName #16201

Merged
merged 3 commits into from
Sep 9, 2021

Commits on Aug 24, 2021

  1. fix(apigatewayv2): ApiMapping does not depend on DomainName

    When an ApiMapping resource is deployed using the Domain defined in the
    DomainName resource, the DomainName resource must be deployed before the
    ApiMapping resource.
    
    Since the current logic uses the CloudFormation Output of DomainName as
    a fall back, preferring the user provided string first, this dependency
    is not expressed in the resulting template.
    
    Remove the preference for the user provided string, will inform
    synthesis that the dependency must be declared.
    
    fixes #15464
    Niranjan Jayakar committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    6e3448a View commit details
    Browse the repository at this point in the history
  2. fix tests

    Niranjan Jayakar committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    d986264 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Configuration menu
    Copy the full SHA
    9dcbf1a View commit details
    Browse the repository at this point in the history