Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-iam): grants support non-identity principals #1623

Merged
merged 40 commits into from
Apr 3, 2019
Merged

feat(aws-iam): grants support non-identity principals #1623

merged 40 commits into from
Apr 3, 2019

Commits on Jan 27, 2019

  1. Introduce Role -> IIdentity -> IPrincipal

    Rico Huijbers committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    19ad316 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2019

  1. feat(aws-iam): grants support non-identity principals 

    Add support for non-identity Principals in grants (for example,
principals that represent accounts or organization IDs). For resources
that support them, the required IAM statements will be added to the
resource policy. For resources that don't support them (because they
don't have resource policies) an error will be thrown.

Add a new `OrganizationPrincipal` principal which represents all
identities in the given AWS Organization.

Fixes #236.
    Rico Huijbers committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    be0ec5d View commit details
    Browse the repository at this point in the history

  2. Forgot to add new file

    Rico Huijbers committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    fcce210 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2019

  1. Merge remote-tracking branch 'origin/master' into huijbers/iam-refactor

    @rix0rrr
    rix0rrr committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    f3c7827 View commit details
    Browse the repository at this point in the history

  2. Undo move of principals to their own file

    @rix0rrr
    rix0rrr committed Feb 11, 2019
    Configuration menu
    Copy the full SHA
    d53d794 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Change grants API

    @rix0rrr
    rix0rrr committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    a445780 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. Make key interface work with jsii

    @rix0rrr
    rix0rrr committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    a43bf24 View commit details
    Browse the repository at this point in the history

  2. Splat in the consumer

    @rix0rrr
    rix0rrr committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    2a75620 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into huijbers/iam-refactor

    @rix0rrr
    rix0rrr committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    dd03daf View commit details
    Browse the repository at this point in the history

  4. Can't have the same function in 2 interfaces in C#

    @rix0rrr
    rix0rrr committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    09cffbd View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into huijbers/iam-refactor

    @rix0rrr
    rix0rrr committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    295d698 View commit details
    Browse the repository at this point in the history

  6. Respect the refactoring

    @rix0rrr
    rix0rrr committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    554816d View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. Add awslint rule to force grant() methods to use helpers

    @rix0rrr
    rix0rrr committed Feb 27, 2019
    3 Configuration menu
    Copy the full SHA
    cf68f7d View commit details
    Browse the repository at this point in the history

  2. WIP

    @rix0rrr
    rix0rrr committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    df46221 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2019

  1. Update API

    @rix0rrr
    rix0rrr committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    8428937 View commit details
    Browse the repository at this point in the history

  2. Update ECS expectations

    @rix0rrr
    rix0rrr committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    81de979 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into huijbers/iam-refactor

    Rico Huijbers committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    0d4ac85 View commit details
    Browse the repository at this point in the history

  4. Make statics also return a Grant

    Rico Huijbers committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    28945ee View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2019

  1. Review comments

    @rix0rrr
    rix0rrr committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    c7391f4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'huijbers/iam-refactor' of github.com:awslabs/aws-cdk in… 

    …to huijbers/iam-refactor
    @rix0rrr
    rix0rrr committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    53f103b View commit details
    Browse the repository at this point in the history

  3. Review comments

    @rix0rrr
    rix0rrr committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    2006891 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into huijbers/iam-refactor

    @rix0rrr
    rix0rrr committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    3323f08 View commit details
    Browse the repository at this point in the history

  5. IRole implementing both IConstruct and IIdentity leads to a C# build … 

    …errror
    @rix0rrr
    rix0rrr committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    b195ac3 View commit details
    Browse the repository at this point in the history

  6. Fix unused import

    @rix0rrr
    rix0rrr committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    49f996e View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2019

  1. awslint should also find indirect interface extensions

    @rix0rrr
    rix0rrr committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    a65d805 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. Merge remote-tracking branch 'origin/master' into huijbers/iam-refactor

    @rix0rrr
    rix0rrr committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    f2eab4e View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. Fixes

    @rix0rrr
    rix0rrr committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    77865f5 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. Merge remote-tracking branch 'origin/master' into huijbers/iam-refactor

    @rix0rrr
    rix0rrr committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    0192f0f View commit details
    Browse the repository at this point in the history

  2. Make it build

    @rix0rrr
    rix0rrr committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    c9349f6 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. Fix failing tests

    @rix0rrr
    rix0rrr committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    929c6fb View commit details
    Browse the repository at this point in the history

  2. Make principal in grant methods nonoptional

    @rix0rrr
    rix0rrr committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    753eb84 View commit details
    Browse the repository at this point in the history

  3. Adding IGrantable (WIP)

    @rix0rrr
    rix0rrr committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    c2ca705 View commit details
    Browse the repository at this point in the history

  4. Adding IGrantable (WIP)

    @rix0rrr
    rix0rrr authored and Rico Huijbers committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    e53474b View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. Merge branch 'huijbers/iam-refactor' of github.com:awslabs/aws-cdk in… 

    …to huijbers/iam-refactor
    Rico Huijbers committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    1b707b1 View commit details
    Browse the repository at this point in the history

  2. Finish introduction of IGrantable, rename Grant.withResource -> Grant… 

    ….onPonPrincipalOrResource
    @rix0rrr
    rix0rrr committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    74bbf35 View commit details
    Browse the repository at this point in the history

  3. Rename grant methods to be more explicit

    @rix0rrr
    rix0rrr committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    71964e7 View commit details
    Browse the repository at this point in the history

  4. Remove dynamodb global

    @rix0rrr
    rix0rrr committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    361a92e View commit details
    Browse the repository at this point in the history

  5. Update IParameter

    @rix0rrr
    rix0rrr committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    3772ba4 View commit details
    Browse the repository at this point in the history

  6. Fix stray unrenamed call

    @rix0rrr
    rix0rrr committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    0d24421 View commit details
    Browse the repository at this point in the history

  7. Make sure JSON.stringify(principal) doesn't recurse indefinitely

    @rix0rrr
    rix0rrr committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    b51c76d View commit details
    Browse the repository at this point in the history