Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate a few modules from nodeunit-shim to jest #16258

Merged
merged 7 commits into from
Aug 28, 2021

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Aug 27, 2021

Part of the the effort to homogenize our testing environment in
the AWS CDK repo involves removing the nodeunit-shim and
using standard jest.

This change applies this to a few modules.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nija-at nija-at requested review from rix0rrr and a team August 27, 2021 15:46
@nija-at nija-at self-assigned this Aug 27, 2021
@gitpod-io
Copy link

gitpod-io bot commented Aug 27, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 27, 2021
Copy link
Contributor

@BenChaimberg BenChaimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like a bunch of the top-level describes are accidentally duplicated

@nija-at nija-at dismissed BenChaimberg’s stale review August 27, 2021 17:42

Responded to comments

@nija-at nija-at requested review from BenChaimberg and a team August 27, 2021 17:43
@mergify
Copy link
Contributor

mergify bot commented Aug 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 0132a1f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d5ca419 into master Aug 28, 2021
@mergify mergify bot deleted the nija-at/nodeunit-shim-remove branch August 28, 2021 14:48
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
Part of the the effort to homogenize our testing environment in
the AWS CDK repo involves removing the nodeunit-shim and
using standard jest.

This change applies this to a few modules.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
Part of the the effort to homogenize our testing environment in
the AWS CDK repo involves removing the nodeunit-shim and
using standard jest.

This change applies this to a few modules.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants