Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): support --no-rollback flag #16293

Merged
merged 3 commits into from
Aug 31, 2021
Merged

feat(cli): support --no-rollback flag #16293

merged 3 commits into from
Aug 31, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Aug 31, 2021

CloudFormation recently released a feature that makes it easier
to iterate quickly on development stacks, where the rollback step
of a deployment is skipped if a deployment fails.

https://aws.amazon.com/de/blogs/aws/new-for-aws-cloudformation-quickly-retry-stack-operations-from-the-point-of-failure/

This allows a developer to fix their code and retry quickly without
losing time waiting for rollbacks.

Fixes #16289.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

CloudFormation recently released a feature that makes it easier
to iterate quickly on development stacks, where the rollback step
of a deployment is skipped if a deployment fails.

This allows a developer to fix their code and retry quickly without
losing time waiting for rollbacks.

Fixes #16289.
@rix0rrr rix0rrr requested a review from a team August 31, 2021 09:31
@rix0rrr rix0rrr self-assigned this Aug 31, 2021
@gitpod-io
Copy link

gitpod-io bot commented Aug 31, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 31, 2021
@eladb
Copy link
Contributor

eladb commented Aug 31, 2021

@skinny85 I think this should be the default when running watch and deploy --hotswap. Can you please add to your PR?

To disable the rollback feature, specify `--no-rollback`:

```console
$ cdk deploy --no-rollback
Copy link
Contributor

@eladb eladb Aug 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this deserves a short alias as well. Maybe -R (stands for "rollback" or "retry")

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Aug 31, 2021
@rix0rrr rix0rrr removed the pr/do-not-merge This PR should not be merged at this time. label Aug 31, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d763d90 into master Aug 31, 2021
@mergify mergify bot deleted the huijbers/no-rollback branch August 31, 2021 11:35
@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 0392aa4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@skinny85 skinny85 mentioned this pull request Aug 31, 2021
11 tasks
@skinny85
Copy link
Contributor

skinny85 commented Sep 2, 2021

@skinny85 I think this should be the default when running watch and deploy --hotswap. Can you please add to your PR?

@eladb Done!

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
CloudFormation recently released a feature that makes it easier
to iterate quickly on development stacks, where the rollback step
of a deployment is skipped if a deployment fails.

https://aws.amazon.com/de/blogs/aws/new-for-aws-cloudformation-quickly-retry-stack-operations-from-the-point-of-failure/

This allows a developer to fix their code and retry quickly without
losing time waiting for rollbacks.

Fixes aws#16289.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
CloudFormation recently released a feature that makes it easier
to iterate quickly on development stacks, where the rollback step
of a deployment is skipped if a deployment fails.

https://aws.amazon.com/de/blogs/aws/new-for-aws-cloudformation-quickly-retry-stack-operations-from-the-point-of-failure/

This allows a developer to fix their code and retry quickly without
losing time waiting for rollbacks.

Fixes aws#16289.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cdk): Add "quickly retry stack operation" feature to CDK
5 participants