Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stepfunctions-tasks): support allocation strategies in EMR CreateCluster #16296

Merged
merged 13 commits into from
Aug 31, 2021
Merged

feat(stepfunctions-tasks): support allocation strategies in EMR CreateCluster #16296

merged 13 commits into from
Aug 31, 2021

Conversation

johsbk
Copy link
Contributor

@johsbk johsbk commented Aug 31, 2021 •
edited by BenChaimberg
Loading

fixes #16252

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 31, 2021

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@johsbk johsbk changed the title feat(step-functions-tasks):Allow allocation strategy Capacity Optimized in Create EMR Cluster feat(step-functions-tasks): Allow allocation strategy Capacity Optimized in Create EMR Cluster Aug 31, 2021
@johsbk
Copy link
Contributor Author

johsbk commented Aug 31, 2021

@BenChaimberg I made a PR and you asked to mention you as reviewer.

@BenChaimberg BenChaimberg self-assigned this Aug 31, 2021
@BenChaimberg BenChaimberg added the pr-linter/exempt-readme The PR linter will not require README changes label Aug 31, 2021
BenChaimberg
BenChaimberg previously requested changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@BenChaimberg BenChaimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the whitespace changes you made to the method definitions

@mergify mergify bot dismissed BenChaimberg’s stale review August 31, 2021 17:11

Pull request has been modified.

@johsbk
Copy link
Contributor Author

johsbk commented Aug 31, 2021

Thanks for quick feedback @BenChaimberg. I have addressed your concerns

BenChaimberg
BenChaimberg previously requested changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@BenChaimberg BenChaimberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the detail, just some touch-ups

also, need to fix linting errors

johsbk and others added 2 commits August 31, 2021 20:05
@johsbk @BenChaimberg
Update packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-c…
20d70ec 
…luster.ts

Co-authored-by: Ben Chaimberg <youppi3@gmail.com>
@johsbk @BenChaimberg
Update packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-c…
d60e036 
…luster.ts

Co-authored-by: Ben Chaimberg <youppi3@gmail.com>
@mergify mergify bot dismissed BenChaimberg’s stale review August 31, 2021 18:06

Pull request has been modified.

@johsbk
Copy link
Contributor Author

johsbk commented Aug 31, 2021

@BenChaimberg final touches added

@BenChaimberg BenChaimberg changed the title feat(step-functions-tasks): Allow allocation strategy Capacity Optimized in Create EMR Cluster feat(stepfunctions-tasks): support allocation strategies in EMR CreateCluster Aug 31, 2021
@BenChaimberg
Copy link
Contributor

Still need to fix linting errors (run yarn lint --fix)

BenChaimberg
BenChaimberg previously approved these changes Aug 31, 2021
View reviewed changes
@mergify mergify bot dismissed BenChaimberg’s stale review August 31, 2021 22:03

Pull request has been modified.

BenChaimberg
BenChaimberg previously approved these changes Aug 31, 2021
View reviewed changes
@mergify mergify bot dismissed BenChaimberg’s stale review August 31, 2021 22:04

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: aef6167
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5a5da57 into aws:master Aug 31, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
@johsbk @TikiTDO
feat(stepfunctions-tasks): support allocation strategies in EMR Creat…
8e7b717 
…eCluster (aws#16296)

fixes aws#16252

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
@johsbk @david-doyle-as24
feat(stepfunctions-tasks): support allocation strategies in EMR Creat…
d7ba92d 
…eCluster (aws#16296)

fixes aws#16252

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenChaimberg BenChaimberg BenChaimberg approved these changes

Assignees

@BenChaimberg BenChaimberg

Labels
@aws-cdk/aws-stepfunctions-tasks pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

step-function-tasks: EMR Create cluster support CapacityOptimised
3 participants
@johsbk @BenChaimberg @aws-cdk-automation