Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(yarn-cling): rename test packages to real package names #16325

Merged
merged 4 commits into from
Sep 1, 2021
Merged

chore(yarn-cling): rename test packages to real package names #16325

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81db622
chore(yarn-cling): rename test packages to real package names
njlynch Sep 1, 2021
35adb22
renaming package2 as well
njlynch Sep 1, 2021
00c6e46
why not. renaming package1 as well
njlynch Sep 1, 2021
9d7cc72
Merge branch 'master' into njlynch/yarn-cling-real-packages
mergify[bot] Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tools/yarn-cling/test/cling.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,20 @@ test('generate lock for fixture directory', async () => {
requires: true,
version: '1.1.1',
dependencies: {
package2: {
'package2': {
njlynch marked this conversation as resolved.
Show resolved Hide resolved
version: '2.2.2',
},
registrydependency1: {
'aws-cdk': {
dependencies: {
registrydependency2: {
'aws-cdk-lib': {
integrity: 'sha512-pineapple',
resolved: 'https://registry.bla.com/stuff',
version: '2.3.999',
},
},
integrity: 'sha512-banana',
requires: {
registrydependency2: '^2.3.4',
'aws-cdk-lib': '^2.3.4',
},
resolved: 'https://registry.bla.com/stuff',
version: '1.2.999',
Expand All @@ -47,18 +47,18 @@ test('generate hoisted lock for fixture directory', async () => {
requires: true,
version: '1.1.1',
dependencies: {
package2: {
'package2': {
version: '2.2.2',
},
registrydependency1: {
'aws-cdk': {
integrity: 'sha512-banana',
requires: {
registrydependency2: '^2.3.4',
'aws-cdk-lib': '^2.3.4',
},
resolved: 'https://registry.bla.com/stuff',
version: '1.2.999',
},
registrydependency2: {
'aws-cdk-lib': {
integrity: 'sha512-pineapple',
resolved: 'https://registry.bla.com/stuff',
version: '2.3.999',
Expand Down
4 changes: 4 additions & 0 deletions tools/yarn-cling/test/test-fixture/package1/node_modules/aws-cdk-lib/package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions tools/yarn-cling/test/test-fixture/package1/node_modules/aws-cdk/package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions tools/yarn-cling/test/test-fixture/package1/node_modules/registrydependency1/package.json
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions tools/yarn-cling/test/test-fixture/package1/node_modules/registrydependency2/package.json
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion tools/yarn-cling/test/test-fixture/package1/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "package1",
"version": "1.1.1",
"dependencies": {
"registrydependency1": "^1.2.3",
"aws-cdk": "^1.2.3",
"package2": "2.2.2"
}
}
4 changes: 2 additions & 2 deletions tools/yarn-cling/test/test-fixture/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
"registrydependency1@^1.2.3":
"aws-cdk@^1.2.3":
version "1.2.999"
resolved "https://registry.bla.com/stuff"
integrity sha512-banana

"registrydependency2@^2.3.4":
"aws-cdk-lib@^2.3.4":
version "2.3.999"
resolved "https://registry.bla.com/stuff"
integrity sha512-pineapple