-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(serverless): add AWS::Serverless::Application to CFN spec #1634
Conversation
@sam-goodwin any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Maybe you can write a small unit test in the @aws-cdk/aws-serverless library that plays with this L1 a little bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
I tested this and it synthesizes "fine", but it doesn't add the Transform to the template so |
Ah, it needs |
Fixed the transform but then ran into:
Also, goformation has been updated with the missing resources: awslabs/goformation#163, but the spec is actually wrong. I submitted a PR with a fix: awslabs/goformation#166 Copy @PaulMaddox |
…dd Transform for Serverless::Application
Fixes #1602
This change adds support for deploying serverless applications from SAR as part of a CDK application:
sam_spec
fromgoformation
as of [Fix] Add Application.Location and fix SSEEnabled awslabs/goformation#166 - brings inAWS::Serverless::Application
andAWS::Serverless:LayerVersion
.CAPABILITY_AUTO_EXPAND
capability to change-sets deployed via the toolkitRefKind
forAWS::Serverless::Application
andAWS::Serverless:LayerVersion
.Example usage:
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.