Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apig): Move 'selectionPattern to integrationResponses` #1636

Merged
merged 1 commit into from
Feb 4, 2019
Merged

fix(apig): Move 'selectionPattern to integrationResponses` #1636

merged 1 commit into from
Feb 4, 2019

Conversation

RomainMuller
Copy link
Contributor

The property was modeled in the wrong place, rendering it unusable.
Moved it to the correct location instead, and added a validation test.

Fixes #1608

Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@RomainMuller
fix(apig): Move 'selectionPattern to integrationResponses`
ffc1641 
The property was modeled in the wrong place, rendering it unusable.
Moved it to the correct location instead, and added a validation test.

Fixes #1608
@RomainMuller RomainMuller requested a review from a team as a code owner January 30, 2019 09:55
@RomainMuller RomainMuller merged commit 7cdbcec into master Feb 4, 2019
@RomainMuller RomainMuller deleted the rmuller/issue-1608 branch February 4, 2019 13:43
moofish32 pushed a commit to moofish32/aws-cdk that referenced this pull request Feb 5, 2019
@RomainMuller @moofish32
fix(apig): Move 'selectionPattern to integrationResponses` (aws#1636)
e3f5ad3 
The property was modeled in the wrong place, rendering it unusable.
Moved it to the correct location instead, and added a validation test.

Fixes aws#1608
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to add more than 1 responses to apigw.AwsIntegration
3 participants
@RomainMuller @eladb @NGL321