Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-ecs): add ASG capacity via Capacity Provider by not specifying machineImageType #16361

Merged
merged 6 commits into from
Oct 12, 2021
Merged

fix(aws-ecs): add ASG capacity via Capacity Provider by not specifying machineImageType #16361

merged 6 commits into from
Oct 12, 2021

Conversation

neilkuan
Copy link
Contributor

@neilkuan neilkuan commented Sep 3, 2021

fix(aws-ecs): make Cluster.addAsgCapacityProvider() not need specify machineImageType

close #16360

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 3, 2021

@pahud
Copy link
Contributor

pahud commented Sep 15, 2021

Hi @madeline-k can you help?

upparekh
upparekh reviewed Oct 11, 2021
View reviewed changes
Copy link
Contributor

@upparekh upparekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @neilkuan , thanks for working on this! The PR looks really good! I just had one question and a suggestion.

packages/@aws-cdk/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/cluster.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/test/cluster.test.ts Outdated Show resolved Hide resolved
@neilkuan
Copy link
Contributor Author

Hi @upparekh , all updated. Please review again, thank you. ☺️

@neilkuan neilkuan requested a review from upparekh October 12, 2021 02:29
@neilkuan neilkuan changed the title fix(aws-ecs): make Cluster.addAsgCapacityProvider() not need specify machineImageType fix(aws-ecs): add ASG capacity via Capacity Provider by not specifying machineImageType Oct 12, 2021
upparekh
upparekh approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@upparekh upparekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution 🚀

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f00232c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 93b3fdc into aws:master Oct 12, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@neilkuan neilkuan deleted the fix-ecs-addAsgCapacityProvider branch November 22, 2021 04:48
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@neilkuan @TikiTDO
fix(aws-ecs): add ASG capacity via Capacity Provider by not specifyin…
c2ee4f1 
…g machineImageType (aws#16361)

fix(aws-ecs): make `Cluster.addAsgCapacityProvider()` not need specify `machineImageType`

close aws#16360 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upparekh upparekh upparekh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(aws-ecs): make Cluster.addAsgCapacityProvider() not need specify machineImageType.
4 participants
@neilkuan @pahud @aws-cdk-automation @upparekh