Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ec2): add c5ad instances #16428

Merged
merged 11 commits into from
Oct 28, 2021
Merged

feat(ec2): add c5ad instances #16428

merged 11 commits into from
Oct 28, 2021

Conversation

cmoore1776
Copy link
Contributor

Innocuous addition of c5ad instance class

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 9, 2021

jumic
jumic suggested changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@jumic jumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add an additional enum value for the concrete instance name, too?

/**
  * Compute optimized instances with local NVME drive based on AMD EPYC, 5th generation  
  */
C5AD = 'c5ad',

You have inserted the new value between COMPUTE5_AMD and C5A. Can you please insert it after C5A? The two values belong together. Therefore, it should be added after C5A.

@peterwoodworth
Copy link
Contributor

Thanks for the contribution @shamelesscookie, and thanks for the review @jumic. Appreciate it

peterwoodworth
peterwoodworth previously requested changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@peterwoodworth peterwoodworth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial, but could you please swap C5A = 'c5a', and COMPUTE5_AMD_NVME_DRIVE = 'c5ad', to make the ones you've added adjacent to each other? Thanks

@peterwoodworth peterwoodworth changed the title chore(ec2): add c5ad instance class chore(ec2): add c5ad instance class Oct 26, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Oct 26, 2021
@mergify mergify bot dismissed peterwoodworth’s stale review October 28, 2021 10:16

Pull request has been modified.

@njlynch njlynch changed the title chore(ec2): add c5ad instance class feat(ec2): add c5ad instances Oct 28, 2021
@njlynch njlynch added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Oct 28, 2021
njlynch
njlynch previously approved these changes Oct 28, 2021
View reviewed changes
@njlynch
Copy link
Contributor

njlynch commented Oct 28, 2021

Thanks for the contribution!

@mergify mergify bot dismissed njlynch’s stale review October 28, 2021 10:32

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: cb51259
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0318253 into aws:master Oct 28, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@cmooreamazon @TikiTDO
feat(ec2): add c5ad instances (aws#16428)
94bdeb0 
Innocuous addition of c5ad instance class

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumic jumic jumic requested changes

@njlynch njlynch njlynch approved these changes

@peterwoodworth peterwoodworth peterwoodworth left review comments

Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cmoore1776 @peterwoodworth @njlynch @aws-cdk-automation @jumic @cmooreamazon