Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route53): Expose VpcEndpointServiceDomainName domain name as a property #16458

Conversation

flemjame-at-amazon
Copy link
Contributor

I want to be able to read the domain name associated with the object.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 10, 2021

@flemjame-at-amazon
Copy link
Contributor Author

Since this is just exposing a property, do I have to change the readme file?

@peterwoodworth peterwoodworth changed the title feat(route53): Expose VpcEndpointServiceDomainName domain name as a property feat(route53): Expose VpcEndpointServiceDomainName domain name as a property Oct 21, 2021
@github-actions github-actions bot added the @aws-cdk/aws-route53 Related to Amazon Route 53 label Oct 21, 2021
@njlynch njlynch added the pr-linter/exempt-readme The PR linter will not require README changes label Oct 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 1cb1aa1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e063fbd into aws:master Oct 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@flemjame-at-amazon flemjame-at-amazon deleted the vpc-endpoint-service-domain-name-properties branch November 1, 2021 14:33
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…roperty (aws#16458)

I want to be able to read the domain name associated with the object.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants