Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudtrail): selector for management event exclusions #16546

Merged

Conversation

vincent-turato
Copy link
Contributor

Closes: #16273


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 19, 2021

@vincent-turato vincent-turato marked this pull request as ready for review September 20, 2021 01:41
@peterwoodworth peterwoodworth changed the title feat(aws-cloudtrail): allow excludeManagementEventSources to be specified for event selectors feat(aws-cloudtrail): allow excludeManagementEventSources to be specified for event selectors Oct 21, 2021
@github-actions github-actions bot added the @aws-cdk/aws-cloudtrail Related to AWS CloudTrail label Oct 21, 2021
@rix0rrr rix0rrr changed the title feat(aws-cloudtrail): allow excludeManagementEventSources to be specified for event selectors feat(cloudtrail): selector for management event exclusions Oct 27, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3cfe8a2 into aws:master Oct 27, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: fc045bd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Closes: aws#16273

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudtrail Related to AWS CloudTrail
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cloudtrail): addEventSelector is missing ExcludeManagementEventSources
3 participants