Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Missing ; makes initialised test fail linting #16637

Merged
merged 7 commits into from
Oct 21, 2021
Merged

chore: Missing ; makes initialised test fail linting #16637

merged 7 commits into from
Oct 21, 2021

Conversation

skymandr
Copy link
Contributor

The missing ; in the template makes the newly generated test file fail linting.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 24, 2021

@mergify
Copy link
Contributor

mergify bot commented Sep 24, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@skymandr skymandr changed the title Missing ; makes initialised test fail linting chore: Missing ; makes initialised test fail linting Sep 24, 2021
@peterwoodworth
Copy link
Contributor

Thanks for the contribution!

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 4e2b3f5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b0d5a57 into aws:master Oct 21, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@skymandr @TikiTDO
chore: Missing ; makes initialised test fail linting (aws#16637)
b16e0fe 
The missing ; in the template makes the newly generated test file fail linting.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwoodworth peterwoodworth peterwoodworth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skymandr @peterwoodworth @aws-cdk-automation