Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): add vpcArn to IVpc and Vpc #16666

Merged
merged 5 commits into from
Oct 25, 2021
Merged

feat(ec2): add vpcArn to IVpc and Vpc #16666

merged 5 commits into from
Oct 25, 2021

Conversation

LukvonStrom
Copy link
Contributor

@LukvonStrom LukvonStrom commented Sep 26, 2021

fixes #16493

introduces context aware ARN for VPC, dervied from the current stack.
This allows easier referencing compared to constructing the ARN from the vpc id.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 26, 2021

@peterwoodworth peterwoodworth changed the title feat(ec2): add attribute to retrieve arn of vpc feat(ec2): add attribute to retrieve arn of vpc Oct 21, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Oct 21, 2021
@njlynch njlynch changed the title feat(ec2): add attribute to retrieve arn of vpc feat(ec2): add vpcArn to IVpc and Vpc Oct 25, 2021
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I made a slight update to add vpcArn to IVpc as well, which should make it more generally useful. Other than that, looks fine.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e85cac2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7b31376 into aws:master Oct 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
fixes aws#16493

introduces context aware ARN for VPC, dervied from the current stack.
This allows easier referencing compared to constructing the ARN from the vpc id.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ec2): Get ARN for VPC
3 participants