Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(amplify): fix files example in BuildSpec.fromObjectToYaml #16701

Merged
merged 3 commits into from
Oct 22, 2021

Conversation

almassapargali
Copy link
Contributor

@almassapargali almassapargali commented Sep 29, 2021

passing files: '**/*' to artifacts doesn't work. It needs to be an array.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 29, 2021

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@almassapargali almassapargali changed the title Fix files example in BuildSpec.fromObjectToYaml docs: fix files example in BuildSpec.fromObjectToYaml Sep 29, 2021
@almassapargali almassapargali changed the title docs: fix files example in BuildSpec.fromObjectToYaml docs(amplify): fix files example in BuildSpec.fromObjectToYaml Sep 29, 2021
skinny85
skinny85 previously approved these changes Sep 29, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @almassapargali!

@mergify mergify bot dismissed skinny85’s stale review October 21, 2021 19:22

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 7f2e7d5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0520ca2 into aws:master Oct 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@almassapargali almassapargali deleted the patch-1 branch October 22, 2021 06:51
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…6701)

passing `files: '**/*'` to artifacts doesn't work. It needs to be an array.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants